Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustification isotropic mesh adaptation + // ls discretization #135

Merged
merged 665 commits into from
Nov 1, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 31, 2024

This PR brings:

  • several bug fixes
  • a first implementation of surface analysis with distributed inputs (still experimental)
  • a first implementation of isovalue discretization (still very experimental):
    • value snapping and manifoldness checks are not yet implemented from distributed inputs (work in progress)

laetitia-m and others added 30 commits January 12, 2024 15:25
…l the tetra and not only on the MG_OLDPBY faces of the tetra
Update point tag with MG_REF if the edge in xtetra is MG_REF + ci tests associated
…e the mesh. memcopy was copying the pointer address only and was leading to double free error
…d par arrays when we have a *mmg3d input file for local parameters or LS references (multimat)
…k_infos to take into account mesh->info.invmat data correctly
… PMMG_mpiunpack_infos function with ier_mesh != 1
…coordinates instead of the minimum global index + first try to debug face2int reallocate memory error
Copy mesh information of local parameters or LS reference (multimat)
Error handling in analysis and level-set discretization
… PMMG_SNAPVAL environment variable is defined (implementation is in progress).
Disable value snapping (implementation in progress)
  - add the -pure-partitioning command line argument
  - the PMMG_IPARAM_puerPartitioning keyword

This allow to only perform mesh partitioning and output file saving (no ls insertion and no remeshing).

For now it works only from centralized input.

Fix small things:
  - set artificially the number of iter to 0 when niter is 0 or pure-repartitioning option is enabled (otherwise the communicators are not saved in medit file and we cannot restart from the medit output)
  - attempt to suitablily set output ls name
  - add writing of output Ls (if allocated) at hdf5 format (It was not called, I don't know why) - not tested
@Algiane Algiane self-assigned this Oct 31, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 72.56410% with 428 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@eaebcbe). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/ls_pmmg.c 73.42% 144 Missing and 42 partials ⚠️
src/analys_pmmg.c 56.72% 54 Missing and 20 partials ⚠️
src/inout_pmmg.c 39.65% 26 Missing and 9 partials ⚠️
src/libparmmg.c 67.04% 12 Missing and 17 partials ⚠️
src/API_functionsf_pmmg.c 0.00% 16 Missing ⚠️
src/API_functions_pmmg.c 60.00% 6 Missing and 8 partials ⚠️
src/libparmmg_tools.c 21.42% 6 Missing and 5 partials ⚠️
src/loadbalancing_pmmg.c 50.00% 10 Missing ⚠️
src/libparmmg1.c 50.00% 8 Missing ⚠️
src/mpiunpack_pmmg.c 38.46% 5 Missing and 3 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage          ?   64.46%           
=========================================
  Files             ?       47           
  Lines             ?    19584           
  Branches          ?     3688           
=========================================
  Hits              ?    12625           
  Misses            ?     5973           
  Partials          ?      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane merged commit 2af15c7 into master Nov 1, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants