Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ls partitioning #134

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Feature/ls partitioning #134

merged 7 commits into from
Oct 31, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 31, 2024

Add the -pure-partitioningoption to partition a centralized input and the associated data (level-set, metric or solution fields) without doing anything else (no ls insertion, no remeshing..).

  - add the -pure-partitioning command line argument
  - the PMMG_IPARAM_puerPartitioning keyword

This allow to only perform mesh partitioning and output file saving (no ls insertion and no remeshing).

For now it works only from centralized input.

Fix small things:
  - set artificially the number of iter to 0 when niter is 0 or pure-repartitioning option is enabled (otherwise the communicators are not saved in medit file and we cannot restart from the medit output)
  - attempt to suitablily set output ls name
  - add writing of output Ls (if allocated) at hdf5 format (It was not called, I don't know why) - not tested
@Algiane Algiane added part: I/O specific to I/Os part: parmmg specific to parmmg code part labels Oct 31, 2024
@Algiane Algiane self-assigned this Oct 31, 2024
@Algiane Algiane merged commit 0105859 into develop Oct 31, 2024
19 of 39 checks passed
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 48.74372% with 102 lines in your changes missing coverage. Please review.

Project coverage is 64.46%. Comparing base (1b12dbc) to head (5bd4d08).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/inout_pmmg.c 40.74% 24 Missing and 8 partials ⚠️
src/libparmmg.c 64.78% 10 Missing and 15 partials ⚠️
src/API_functionsf_pmmg.c 0.00% 16 Missing ⚠️
src/API_functions_pmmg.c 60.00% 6 Missing and 8 partials ⚠️
src/libparmmg_tools.c 23.07% 5 Missing and 5 partials ⚠️
src/mpiunpack_pmmg.c 0.00% 1 Missing and 2 partials ⚠️
src/mergemesh_pmmg.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
+ Coverage    63.86%   64.46%   +0.60%     
===========================================
  Files           47       47              
  Lines        19458    19584     +126     
  Branches      3649     3688      +39     
===========================================
+ Hits         12427    12625     +198     
+ Misses        6067     5973      -94     
- Partials       964      986      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: I/O specific to I/Os part: parmmg specific to parmmg code part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant