Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable value snapping (implementation in progress) #133

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 30, 2024

Enable value snapping in distributed ls discretization mode only when PMMG_SNAPVALenvironment variable is defined (implementation of the distributed value snapping is in progress).

… PMMG_SNAPVAL environment variable is defined (implementation is in progress).
@Algiane Algiane added kind: cleanup should be clean part: parmmg specific to parmmg code part part: ls discretization isovalue mode specificty labels Oct 30, 2024
@Algiane Algiane self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.72%. Comparing base (6c00cae) to head (3e0ec64).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
src/ls_pmmg.c 50.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #133   +/-   ##
========================================
  Coverage    63.72%   63.72%           
========================================
  Files           47       47           
  Lines        19419    19421    +2     
  Branches      3632     3632           
========================================
+ Hits         12375    12377    +2     
  Misses        6098     6098           
  Partials       946      946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane merged commit 1b12dbc into develop Oct 31, 2024
41 of 42 checks passed
@Algiane Algiane deleted the feature/disable_snap_val branch October 31, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup should be clean part: ls discretization isovalue mode specificty part: parmmg specific to parmmg code part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant