Error handling in analysis and level-set discretization #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt to maintain edge tags consistency in grp_split: for now, edges of xtetra of new mesh are updated if they belong to a boundary face.
Solves missing MG_NOM and MG_REF tags when a rank has a nom edge but without any physical boudary on it. See the following test: ``` parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0 ```
… detection).
Along // edges, non-manifold analysis and information sharing is done inside the PMMG_setdhd function, thus it was skipped in -nr mode.
See the following test:
```
parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0 -nr
```
…ecking mesh edge consistency.
…collapse) in swap23.
…edge tags are consistents.
- If a mesh is subdivided into 3 partitions with 3 MPI processes, an edge provided as ref edge at input by the user will miss the MG_REF tag if it blongs to only purely parallel faces on a partition. The tag is suitably set to REF on the other partitions, leading to non-consistency. - fixes ls ls-DisIn-toygeom-faces-5 test case
…a consistency check at end of analysis.
… EDG tag at point along non EDG edge due to spurious input surface triangles matching the // interface).
…o cannot be used.
…ot ad PARBDYBDY tags on temporary triangles that are finally deleted when storing the tags inside the xtetra.
… singular extremities.
…ges are not marked as ridges anymore).
…, nom edges are not marked as ridges anymore)." This reverts commit fdabace: for now, we tag non-consistency if we don't add the MG_GEO tag at the same time than the MG_NOM one. I have no time to look at this now... postponed
…lock can occur if 1 rank fail (to improve).
Algiane
added
part: parmmg
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #132 +/- ##
===========================================
- Coverage 63.76% 63.72% -0.04%
===========================================
Files 47 47
Lines 19275 19419 +144
Branches 3600 3632 +32
===========================================
+ Hits 12290 12375 +85
- Misses 6056 6098 +42
- Partials 929 946 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to handle errors in parallel level set discretization and surface analysis: due to lack of time,
MPI_Abortcalls are temporary used to avoid deadlocks in communications when one mpi process fail but not the others.