Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge tag consistency #129

Merged
merged 39 commits into from
Oct 29, 2024
Merged

Edge tag consistency #129

merged 39 commits into from
Oct 29, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 25, 2024

This PR:

  • adds multiple checks for tag consistency inside meshes;
  • solves multiple issues raised by these checks.

Algiane and others added 30 commits August 22, 2024 10:00
@Algiane
Maintain edge tag consistency in group_split
839fe77 
First attempt to maintain edge tags consistency in grp_split: for now, edges of xtetra of new mesh are updated if they belong to a boundary face.
@Algiane
Modif of edge tag update in updateTag.
451599b
@Algiane
Modif of edge tag update after group splitting.
8ee20c9
@Algiane
TO REVERT : Add checks to validate the previous modifications.
4a5e687
@Algiane
Whitespace cleanup + improve code comments.
9a8ae17
@Algiane
Solve inconsistencies in // analysis of non-manifold edges.
7edb110 
Solves missing MG_NOM and MG_REF tags when a rank has a nom edge but without any physical boudary on it.
See the following test:
```
parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0
```
@Algiane
Solve missing // analysis of non-manifold edges in -nr mode (no ridge…
f57d194 
… detection).

    Along // edges, non-manifold analysis and information sharing is done inside the PMMG_setdhd function, thus it was skipped in -nr mode.

    See the following test:
    ```
    parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0 -nr
    ```
@Algiane
Rename PMMG_setdhd function into PMMG_setfeatures.
00a564e
@Algiane
Point to Mmg commit in which MMG5_OLD_PARBDY tags are ignored when ch…
f119be5 
…ecking mesh edge consistency.
@Algiane
Update Mmg tag after edge tag fix in swap23.
a17a3e9
@Algiane
Update Mmg tag after fix of wrong edge tag (due to missing tag after …
0b98e30 
…collapse) in swap23.
@Algiane
Update Mmg tag after swap23 fix.
b22d42b
@Algiane
Update tag types (int16_t -> unint16_t).
9a554ce
@Algiane
Update comments + remove useless preprocessor test.
d09630a
@Algiane
Refactoring in PMMG_setfeatures function.
d2ccead
@Algiane
Fix erroneous point tag after point insertion along REF edge in level…
0b1afdc 
…-set splitting.
@Algiane
Add an assert on the edge tag.
30df811
@Algiane
Remove erroneous assert: edges may lie along PARBDYBDY faces too.
18a3d8a
@Algiane
Remove obsolete warning: with all the performed tests, it seems that …
fbb8f0c 
…edge tags are consistents.
@Algiane
Update Mmg tag after second fix in swap23 (should solve lsCenIn-2 tes…
cc2c797 
…t case).
@Algiane
Refactoring: rename functions + update comments.
b94434b
@Algiane
Fix possible inconsistency between MG_REF edge tags.
c97fe45 
  - If a mesh is subdivided into 3 partitions with 3 MPI processes, an
edge provided as ref edge at input by the user will miss the MG_REF tag
if it blongs to only purely parallel faces on a partition. The tag is
suitably set to REF on the other partitions, leading to non-consistency.

  - fixes ls ls-DisIn-toygeom-faces-5 test case
@Algiane
Update Mmg tag to not check PARBDYBDY consistency + update doc + add …
ddfc4da 
…a consistency check at end of analysis.
@Algiane
Fix division by 0 when computing the tangent at EDG point (issue with…
35ddd83 
… EDG tag at point along non EDG edge due to spurious input surface triangles matching the // interface).
@Algiane
Fix previous commit: intvalue array is erased at function beginning s…
ba27447 
…o cannot be used.
@Algiane
Reset ls references before analysing parallel triangles in order to n…
cdf19dc 
…ot ad PARBDYBDY tags on temporary triangles that are finally deleted when storing the tags inside the xtetra.
@Algiane
Update Mmg tag.
0e467d3
@Algiane
Add support for empty group in parbdyTria.
cd157e1
@Algiane
Add checks for mesh consistency in CMake Debug mode.
fe69e60
@Algiane
Merge branch 'develop' into feature/edge-tag-consistency
60b5da1
@Algiane Algiane added kind: bug Something isn't working kind: enhancement enhancement to an existing feature part: mmg3d / mesh specific to mmg3d code part or meshing techniques part: parmmg specific to parmmg code part part: analysis labels Oct 25, 2024
@Algiane Algiane self-assigned this Oct 25, 2024
@Algiane Algiane changed the base branch from master to develop October 25, 2024 14:29
@Algiane
Merge branch 'develop' into feature/edge-tag-consistency
d6162e7
@Algiane
Update git tag to avoid issue with wrong normal along nom edge with 2…
12b0390 
… singular extremities.
@Algiane
Check for truely required edges when ensuring edge consistency after …
b9a3cc8 
…group splitting.
@Algiane
Remove MG_GEO marker from MG_NOM edges in // analysis (in Mmg, nom ed…
fdabace 
…ges are not marked as ridges anymore).
@Algiane
Revert "Remove MG_GEO marker from MG_NOM edges in // analysis (in Mmg…
5a780db 
…, nom edges are not marked as ridges anymore)."

This reverts commit fdabace: for now, we tag non-consistency if we don't add the MG_GEO tag at the same time than the MG_NOM one. I have no time to look at this now... postponed
@Algiane
Remove debug prints.
d7b2439
@Algiane
Merge branch 'feature/edge-tag-consistency' of github.com:MmgTools/Pa…
b81abb2 
…rMmg into feature/edge-tag-consistency
@Algiane
Remove debug prints.
fc412d0
@Algiane
Remove debug prints.
6063bc0
@Algiane Algiane closed this Oct 29, 2024
@Algiane Algiane reopened this Oct 29, 2024
@Algiane Algiane merged commit 86b3956 into develop Oct 29, 2024
20 of 40 checks passed
@Algiane Algiane deleted the feature/edge-tag-consistency branch October 31, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Algiane Algiane

Labels
kind: bug Something isn't working kind: enhancement enhancement to an existing feature part: analysis part: mmg3d / mesh specific to mmg3d code part or meshing techniques part: parmmg specific to parmmg code part
Projects
Robustness improvement
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Algiane