Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API_DISTRIB_FACES prioritized over API_DISTRIB_NODES #112

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

corentin-prigent
Copy link

@corentin-prigent corentin-prigent commented Apr 23, 2024

If both parallel nodes and parallel faces are provided, only parallel faces are kept for building communicators, regardless of order of data in input files.

@corentin-prigent corentin-prigent changed the base branch from master to develop April 23, 2024 09:47
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (535b533) to head (aa2de6a).
Report is 3 commits behind head on develop.

Files Patch % Lines
src/inout_pmmg.c 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #112      +/-   ##
===========================================
- Coverage    63.15%   63.14%   -0.01%     
===========================================
  Files           46       46              
  Lines        18960    18962       +2     
  Branches      3546     3548       +2     
===========================================
  Hits         11974    11974              
- Misses        6059     6060       +1     
- Partials       927      928       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Algiane Algiane added kind: bug Something isn't working part: I/O specific to I/Os part: parmmg specific to parmmg code part labels Apr 25, 2024
@Algiane Algiane force-pushed the feature/api-distrib-faces branch from 8c779eb to aa2de6a Compare August 21, 2024 18:43
@Algiane Algiane merged commit c224b90 into MmgTools:develop Aug 22, 2024
21 of 22 checks passed
@corentin-prigent corentin-prigent deleted the feature/api-distrib-faces branch August 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working part: I/O specific to I/Os part: parmmg specific to parmmg code part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants