Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with extra triangles in input mesh #110

Merged
merged 14 commits into from
Sep 12, 2024

Conversation

corentin-prigent
Copy link

This update allows for the presence of extra internal triangles in the input mesh. Mesh packing would lead to incorrect triangle indices in the internal communicators.

@Algiane Algiane added kind: bug Something isn't working part: I/O specific to I/Os part: parmmg specific to parmmg code part labels Apr 25, 2024
@Algiane Algiane force-pushed the feature/permutation-array branch from 02caae3 to 95683ec Compare August 21, 2024 18:45
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.23%. Comparing base (c224b90) to head (48862c0).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/libparmmg.c 60.00% 0 Missing and 2 partials ⚠️
src/analys_pmmg.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
+ Coverage    63.14%   63.23%   +0.08%     
===========================================
  Files           46       46              
  Lines        18962    18978      +16     
  Branches      3548     3553       +5     
===========================================
+ Hits         11974    12001      +27     
+ Misses        6060     6049      -11     
  Partials       928      928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just possible to add or modify a test so that it fails before the fix and is solved by the PR ?
Thanks by advance

@Algiane Algiane merged commit e02e4e5 into MmgTools:develop Sep 12, 2024
22 checks passed
@Algiane
Copy link
Member

Algiane commented Sep 12, 2024

Thx

@corentin-prigent corentin-prigent deleted the feature/permutation-array branch September 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working part: I/O specific to I/Os part: parmmg specific to parmmg code part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants