-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems with extra triangles in input mesh #110
Fix problems with extra triangles in input mesh #110
Conversation
02caae3
to
95683ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #110 +/- ##
===========================================
+ Coverage 63.14% 63.23% +0.08%
===========================================
Files 46 46
Lines 18962 18978 +16
Branches 3548 3553 +5
===========================================
+ Hits 11974 12001 +27
+ Misses 6060 6049 -11
Partials 928 928 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just possible to add or modify a test so that it fails before the fix and is solved by the PR ?
Thanks by advance
Thx |
This update allows for the presence of extra internal triangles in the input mesh. Mesh packing would lead to incorrect triangle indices in the internal communicators.