-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort if nosplit
option used in multimat mode
#108
Abort if nosplit
option used in multimat mode
#108
Conversation
src/ls_pmmg.c
Outdated
ref = mat->ref; | ||
refint = mat->rin; | ||
refext = mat->rex; | ||
if ( (ref == refint) & (ref == refext) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&&
instead of &
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
src/ls_pmmg.c
Outdated
if ( parmesh->info.imprim > PMMG_VERB_VERSION ) { | ||
fprintf(stdout,"\n -- WARNING: The option `nosplit` in multimat is not supported yet.\n\n\n"); | ||
PMMG_RETURN_AND_FREE( parmesh, PMMG_LOWFAILURE ); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the option is not supported, you always want to stop the process so I would always print an error message and exit, not only in case of PMMG_VERB_VERSION
verbosity:
fprintf(stderr,"\n -- ERROR: The option `nosplit` in multimat is not supported yet.\n\n\n");
PMMG_RETURN_AND_FREE( parmesh, PMMG_LOWFAILURE );
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done + modify return to be 0
instead of PMMG_RETURN_AND_FREE
(here and elsewhere in the file too).
Thanks! |
For now (until the overlap), the multimat mode does not support the
nosplit
option in*.mmg3d
file.This PR raises a warning and stops the code if the option
nosplit
is used.