Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update point tag with MG_REF if the edge in xtetra is MG_REF + ci tests associated #103

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

laetitia-m
Copy link
Contributor

Update the point tag with MG_REF if the edge in xtetra is MG_REF in the analysis update.
After load balancing, the analysis need to be updated (PMMG_update_analys), in particular, the point tag might not be up to date regarding the tag MG_REF. Indeed, if in the input distributed meshes one Edge is also a ParallelEdge, the tag MG_REF to the point is not assigned properly by the analysis because parallel interfaces are systematically skipped (for example, see condition if(((pt->tag[i] & MG_PARBDY) && !(pt->tag[i] & MG_PARBDYBDY)) || (pt->tag[i] & MG_BDY) ) continue; in MMG5_setadj). This is not an issue in the first iteration, however after the load balancing and in the second iteration, point tags need to be up to date. To do so, the function PMMG_updateTagRef_node is now added when the analysis is updated.

CI tests

  1. Add ci test for the update of the point tag with tag MG_REF
  2. Update testparmmg git tag to point towards the latest master version
  3. Update ci tests regarding the latest reorganization of testparmmg folder
  4. Include LS and field ci test in the IF ( NOT ONLY_LIBRARY_TESTS )

@Algiane Algiane added kind: bug Something isn't working part: parmmg specific to parmmg code part part: surface specific to surface operators labels Feb 8, 2024
…l the tetra and not only on the MG_OLDPBY faces of the tetra
Copy link
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Algiane Algiane merged commit 10aef01 into MmgTools:develop Feb 8, 2024
18 of 19 checks passed
@laetitia-m laetitia-m deleted the feature/update-ref-tag branch February 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working part: parmmg specific to parmmg code part part: surface specific to surface operators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants