Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript type errors #12

Merged
merged 6 commits into from
Sep 2, 2023
Merged

Fix TypeScript type errors #12

merged 6 commits into from
Sep 2, 2023

Conversation

Mimickal
Copy link
Owner

@Mimickal Mimickal commented Sep 2, 2023

This release fixes some scenarios where TypeScript would report type incompatibilities in builders.

  • .addXOption functions from Discord.js now preserve type information.
  • Handler functions now determine interaction type better.
  • Handler functions don't cause TypeScript errors anymore (no idea how I didn't catch this the first time around).

@Mimickal Mimickal merged commit 5b10d1d into master Sep 2, 2023
4 checks passed
@Mimickal Mimickal deleted the ts-subcommand-fix branch September 2, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mimickal