Feature/type annotations #38
Conversation
|
It looks like 25% of Python 3 users are still using versions earlier than 3.6; since type annotation is just unenforced syntactic sugar, I'd like to hold off until almost everyone is using 3.6 or newer. When the numbers improve, we can make the change - after documenting which ebmlite versions are compatible with which Python versions. |
|
Agreed, I'm going to leave this as a draft for now. If someone really wants it, this is available. |
# Conflicts: # ebmlite/util.py
…nnotations # Conflicts: # ebmlite/core.py
Codecov Report
@@ Coverage Diff @@
## development #38 +/- ##
===============================================
+ Coverage 61.77% 61.86% +0.08%
===============================================
Files 12 12
Lines 1308 1311 +3
===============================================
+ Hits 808 811 +3
Misses 500 500
Continue to review full report at Codecov.
|
| os.path.realpath(os.path.dirname(schemata.__file__))] | ||
|
|
||
| # SCHEMATA: A dictionary of loaded schemata, keyed by filename. Used by | ||
| # `loadSchema()`. In most cases, SCHEMATA should not be otherwise modified. | ||
| SCHEMATA = {} | ||
| SCHEMATA: Dict[Union[str, bytes, bytearray], Any] = {} |
There was a problem hiding this comment.
I think the keys will always be string.
| DEFAULT_FLOAT_SIZE: int = 4 if sys.maxsize <= 2147483647 else 8 | ||
|
|
||
| LENGTH_PREFIXES: List[int] = [0, |
There was a problem hiding this comment.
Do internally-used constants need typing?
There was a problem hiding this comment.
I probably got a little over-zealous when I originally did this, honestly.
| @@ -218,7 +219,7 @@ def encodeBinary(val, length=None): | |||
| (len(val), length)) | |||
|
|
|||
|
|
|||
| def encodeString(val, length=None): | |||
| def encodeString(val: ByteString, length: Optional[int] = None): | |||
There was a problem hiding this comment.
Should also include str... from the EBML spec, the subset-of-ASCII limitation is on the storage, and the data is still considered to be strings.
|
Annotation done in PR #127, closing this one. |
Pull request for python 3.6 style type annotations. Leaving as a draft for now because it breaks compatibility with 3.5.