Drupal Code Quality Checker

[Brian-Clement]

No description provided.

[froboy]

I have... feelings about this... the one other project I'm on that uses pre-commit hooks takes close to a minute to run checks and it's... a pain to work with. I'd much rather run checks in CI, where I don't get yelled at until I'm asking to be, but I'm open to discussion here, as this is definitely a much smaller project and I'd imagine the checks take much less time.

[Brian-Clement]

I'm certainly up for further discussion on it, but these don't take much time at all in here at the minute (a few seconds). I would love to have real CI one day...

[froboy]

Cool. I’m happy to call my 1 experience an exception and not the rule, and tbf I didn’t test this. :)

…

On Wed, Oct 16, 2019 at 7:29 PM Brian Clement ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#287 (comment)>: > -### Patching modules +[GrumPHP](https://github.com/phpro/grumphp) is included for linting and enforcing Drupal code quality standards. This will run on a Git `pre-commit` hook based on the files you are attempting to commit. When you run `git commit -m "My message"` GrumPHP will check your code and potentially prevent you from committing until issues are resolved. I'm certainly up for further discussion on it, but these don't take much time at all in here at the minute (a few seconds). I would love to have real CI one day... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#287?email_source=notifications&email_token=AAB2E6LVTFSTILOUCQFS4PTQO6WVNA5CNFSM4I4MR5P2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIHKEOI#discussion_r335765917>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2E6NV75SL2CXKH5P6BJ3QO6WVNANCNFSM4I4MR5PQ> .