Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update officespace-software-provisioning-tutorial.md #1241

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jferguson2021
Copy link

Updated screenshots for the OfficeSpace software side of this guide, and accompanying directions.

Updated screenshots for the OfficeSpace software side of this guide, and accompanying directions.
Copy link
Contributor

@jferguson2021 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @thomasakelo

Copy link
Contributor

Learn Build status updates of commit aae936f:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/officespace-software-provisioning-tutorial.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 14, 2024

@owinoakelo
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@owinoakelo
Copy link
Contributor

@ZollnerdMSFT can you review this PR and sign off.
@Jak-MS can you transfer the ownership of this to Danny?

@ZollnerdMSFT
Copy link
Contributor

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @thomasakelo

Copy link
Contributor

Learn Build status updates of commit 893364e:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/officespace-software-provisioning-tutorial.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 537796a:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/saas-apps/officespace-software-provisioning-tutorial.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 14, 2024

@jferguson2021 @ZollnerdMSFT - all images in the article must be uploaded to the repo... and not in a github user-attachments folder. @jferguson2021 : can you put the images into the (media/officespace-software-provisioning-tutorial/) folder as .pngs? you'll need to follow our naming convention (all lowercase characters, full words, separated by hyphens).

thanks ... ping me or add #sign-off when that has been done and you're ready for another review. thanks!
#hold-off

Copy link
Contributor

You typed hold-off, but the PR wasn't signed off, so nothing was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants