-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bees algorithm #6
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
- Coverage 100.00% 90.27% -9.73%
===========================================
Files 2 3 +1
Lines 4 144 +140
===========================================
+ Hits 4 130 +126
- Misses 0 14 +14
Continue to review full report at Codecov.
|
…to BeesAlgorithm
…to BeesAlgorithm
…to BeesAlgorithm
…to BeesAlgorithm
Needs to be reviewed by @KobeDeTemmerman and @Cengoni. |
Nice project, I would maybe shorten the general explanation of the algorithm in the documentation, with the notebook available this might be a little bit of an overkill. The input and output explanations are not always necessary, but I understand that you want to be consistent. If I run the tests I get an error, they don't fail but there is an error, because the objective_value and the initial_population functions can't be found. I tried to export them by your module but that didn't solve it. For the rest the code looks great. |
…to BeesAlgorithm
…to BeesAlgorithm
…to BeesAlgorithm
@KobeDeTemmerman thank you for the nice feedback, indeed there were some errors in the package that occurred because of last changes. We fixed the errors and everything works now. I assume you couldn't open the notebook as well but now this should be possible without any further efforts (feel free to check it out, it's very nice). Again our sincere apologies for the code issues and hope u enjoyed it. grtz |
Pull request from correct branch