Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small feedback from a peer. #38

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

juhlee
Copy link

@juhlee juhlee commented Jan 31, 2022

Hello Thiemen!

I just ran and read your notebook, and I really thought the notebook was impressive: the structure was nice and the content was very informative.

Just as a person who overused PlutoUI in his project, the only comment I can give is the visualization in the implementation section.

Maybe a bar chart to better visualize the differing iterations between algorithms? or maybe a line graph of how LMA requires more iterations with increasing lambda values?

It already looks great. Take my feedback with a grain of salt.

@ppm1337
Copy link

ppm1337 commented Jan 31, 2022

Hey Thiemen,

very detailed notebook on GNA and LMA! I very much enjoyed the metaphorical image 🍧 and liked how you progressively explained the formulas. One simple suggestion: It would really add to the notebook if you not leave the reader with her pure imagination but also add a few images to your notebook to better illustrate the matter. You don't even have to create plots yourself, e.g. for the famous Rosenbrock function there are tons of CC-BY-SA licensed images out there.

If you are concerned about formatting issues, please check the intermezzo on Taylor approximations: "Replacing x in the polynomial is possible because [...]" is wrongly formatted.

Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants