Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add first example #28

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Conversation

MichielStock
Copy link
Owner

No description provided.

@MichielStock
Copy link
Owner Author

It looks quite promising, but at the moment it is a bit vague what it is going to do. Make sure to write the introduction very clearly so people will understand the goal (it is always a challenge that more fun examples are harder to follow). Of course, MAP-Elites has to be outlined as well.

There are some things that make your life easier:
sum([f(x) for x in vector]) => sum(f, vector)
any([f(x) for x in vector]) => any(f, vector)

Also some stylistic things: only types have a capital, variables not, so attacker, functions also need to be lower case: battle, create_army etc.

I am curious to see where this is going!

@CeriAnneLaureyssens
Copy link

Hey Ward, first off I want to tell you I had a lot of fun with your notebook! I really enjoyed the tool you made (might use it later 😄 ).

It's really nicely structured which makes it easy to understand and follow! Maybe just a small remark, but in the Neighbour function you state "adapt the fridgeList so that only ingredients from the removed ingredient are available", is it possible that you mean recipe instead of ingredient?

@ppm1337
Copy link

ppm1337 commented Jan 31, 2022

Hey Ward,

I haven't had breakfast, yet. So your project really made me hungry!
I agree with Ceri-Anne that your project is well-structured. The experimental section is super valuable and adds another layer of interactivity to your notebook. And on top of that, the recipe scraper made experimenting with your notebook super accessible.

For my fridge, which currently also just contains the example ingredients ("chocolate", "potato", "salt", "cheese") your algorithm wants me to drink beer? How would you explain that? If you receive soft money from the alcoholic beverage industry maybe add an acknowledgment to your notebook. 😄✌

From worker 7:    Found chocolate in the ingredient database.
From worker 7:    Found potato in the ingredient database.
From worker 7:    Found salt in the ingredient database.
From worker 7:    Found cheese in the ingredient database.
From worker 7:    Done checking ingredients.
From worker 7:
From worker 7:    The best recipes to make are:
From worker 7:
From worker 7:    Frieten  (Belgian French Fries) : Any["potato", "salt", "oil"]
From worker 7:    Gourmet Belgian Hot Chocolate : Any["milk", "vanilla bean", "chocolate"]
From worker 7:    Stella & Tanqueray Chillin & Sippin.... : Any["beer"]

Joking aside, keep it up!

One minor suggestion: Not sure if you did it on purpose, but if you add the doc strings of the functions in the appendix above the function, you will get a nicely formatted documentation.

@wardvanbelle
Copy link

Hey Ward, first off I want to tell you I had a lot of fun with your notebook! I really enjoyed the tool you made (might use it later 😄 ).

It's really nicely structured which makes it easy to understand and follow! Maybe just a small remark, but in the Neighbour function you state "adapt the fridgeList so that only ingredients from the removed ingredient are available", is it possible that you mean recipe instead of ingredient?

Yes that should indeed be recipe! Thanks for the feedback

@wardvanbelle
Copy link

Hey Ward,

I haven't had breakfast, yet. So your project really made me hungry! I agree with Ceri-Anne that your project is well-structured. The experimental section is super valuable and adds another layer of interactivity to your notebook. And on top of that, the recipe scraper made experimenting with your notebook super accessible.

For my fridge, which currently also just contains the example ingredients ("chocolate", "potato", "salt", "cheese") your algorithm wants me to drink beer? How would you explain that? If you receive soft money from the alcoholic beverage industry maybe add an acknowledgment to your notebook. 😄✌

From worker 7:    Found chocolate in the ingredient database.
From worker 7:    Found potato in the ingredient database.
From worker 7:    Found salt in the ingredient database.
From worker 7:    Found cheese in the ingredient database.
From worker 7:    Done checking ingredients.
From worker 7:
From worker 7:    The best recipes to make are:
From worker 7:
From worker 7:    Frieten  (Belgian French Fries) : Any["potato", "salt", "oil"]
From worker 7:    Gourmet Belgian Hot Chocolate : Any["milk", "vanilla bean", "chocolate"]
From worker 7:    Stella & Tanqueray Chillin & Sippin.... : Any["beer"]

Joking aside, keep it up!

One minor suggestion: Not sure if you did it on purpose, but if you add the doc strings of the functions in the appendix above the function, you will get a nicely formatted documentation.

That is indeed a bit weird! I will surely look into it. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants