-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross Entropy #26
base: master
Are you sure you want to change the base?
Cross Entropy #26
Conversation
First check-up file There still has to be done some layouting, inserting some more descriptive comments to the code itself, some examples on how and when to use the code, and (maybe) adding some visuals
Looks nice!
Good luck! |
Something is wrong with the notebook file. Better fix this! |
Should be okay now, I made a mistake by deleting my old file and removing the folder completely. My bad |
take care of mathematics: \text{argmin} \log (so they are correctly typeset in math mode). If you use images, just copy the link |
Version to be checked by other students
Hi! I just took a look at your notebook and I'm very impressed with your coding skills, nice job! The subject you chose definitely doesn't seem like one of the easiest, so I think the project might benefit from a little bit more explanation or examples about what this technique is actually concretely used for. Some other small remarks:
|
ArgumentError: invalid index: :x of type Symbol
So maybe you could provide an example for running the function with the argument “batched = true”
For the rest, good job, it doesn’t seem like an easy algorithm to implement (e.g. the package Distributions it’s totally new for me…). |
@MichielStock I have uploaded my final version on my GitHub repo and on Ufora |
First check-up file
There still has to be done some layouting, inserting some more descriptive comments to the code itself, some examples on how and when to use the code, and (maybe) adding some visuals