Code

Performance Refactoring#128

Code

Merged

bpepple merged 23 commits intomainMetron-Project/metron-tagger:mainfrom devMetron-Project/metron-tagger:devCopy head branch name to clipboardJul 6, 2024

+207-190

Commits

Commits on Jul 1, 2024

• Add function to extract comic id

  bpepple

  committed
  3203289

Commits on Jul 4, 2024

• make extract_id_str private

  bpepple

  committed
  b3f32b3

• Extract the conditional logic for collection into a separate variable

  bpepple

  committed
  eaca3b6

• Move conf init to beginning

  bpepple

  committed
  6e96444

• Extracted the common questionary.print call into a helper function to reduce redundancy.

  bpepple

  committed
  f362d86

• Update pre-commit config

  bpepple

  committed
  075643e

• Ignore PLR0915

  bpepple

  committed
  068e3f7

• Combine repetitive logic and simplify conditional checks

  bpepple

  committed
  c58ae10

• Parse the document only once.

  bpepple

  committed
  e756112

• Refactor to improve performance

  Show description for ecf6259
  bpepple

  committed
  ecf6259

• Refactor get_comic_list_from_hash()

  Show description for 26fc2f3
  bpepple

  committed
  26fc2f3

• Refactor delete_comic_pages()

  Show description for 0a4d1b0
  bpepple

  committed
  0a4d1b0

• Refactor get_comic_info_for_distinct_hash()

  Show description for 9e737c2
  bpepple

  committed
  9e737c2

• Refactor _get_page_hashes()

  Show description for aaa78a0
  bpepple

  committed
  aaa78a0

• Refactor get_distinct_hashes()

  Show description for 9f6ce54
  bpepple

  committed
  9f6ce54

• Refactor show_image()

  Show description for 0ca7dc2
  bpepple

  committed
  0ca7dc2

• Rework duplicate tests

  bpepple

  committed
  d9fb8d1

• Refactor _remove_empty_separators()

  Show description for 83a5726
  bpepple

  committed
  83a5726

• Refactor _remove_duplicate_hyphen_underscore()

  Show description for aaf5877
  bpepple

  committed
  aaf5877

• Refactor smart_cleanup_string()

  Show description for ce7145a
  bpepple

  committed
  ce7145a

• Refactor smart_cleanup_string()

  Show description for 196c3cd
  bpepple

  committed
  196c3cd

Commits on Jul 6, 2024

• Add dep on tqdm

  bpepple

  committed
  cea1936

• Use progressbar instead of print statements

  Show description for 0c61fac
  bpepple

  committed
  0c61fac