Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mm-login): improve metamask login #1572

Merged
merged 5 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions src/components/AuthLogin/AuthModal.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { useContext, useEffect } from "react";
import Modal from "react-modal";
import useDocusaurusContext from "@docusaurus/useDocusaurusContext";
import { useLocation } from "@docusaurus/router";
import styles from "./styles.module.css";
import global from "../ParserOpenRPC/global.module.css";
import Icon from "../Icon/Icon";
Expand All @@ -11,7 +12,7 @@ import {
saveTokenString,
getUserIdFromJwtToken,
} from "../../lib/siwsrp/auth";
import { DASHBOARD_URL, REQUEST_PARAMS } from "@site/src/lib/constants";
import { DASHBOARD_URL, REQUEST_PARAMS, REF_PATH } from "@site/src/lib/constants";
import { MetamaskProviderContext } from "@site/src/theme/Root";

Modal.setAppElement("#__docusaurus");
Expand Down Expand Up @@ -130,15 +131,20 @@ const ConnectionErrorModal = ({
);
};

const AuthModal = ({
open,
setOpen,
step,
setStep,
}: AuthModalProps) => {
const AuthModal = ({ open, setOpen, step, setStep }: AuthModalProps) => {
const { siteConfig } = useDocusaurusContext();
const { DASHBOARD_PREVIEW_URL, VERCEL_ENV } = siteConfig?.customFields || {};
const { sdk, setWalletLinked, setWalletLinkUrl, metaMaskDisconnect, setProjects, setMetaMaskAccount, setMetaMaskProvider } = useContext(MetamaskProviderContext);
const {
sdk,
setWalletLinked,
setWalletLinkUrl,
metaMaskDisconnect,
setProjects,
setMetaMaskAccount,
setMetaMaskProvider,
} = useContext(MetamaskProviderContext);
const location = useLocation();
const { pathname } = location;

const login = async () => {
setStep(AUTH_LOGIN_STEP.CONNECTING);
Expand All @@ -155,10 +161,12 @@ const AuthModal = ({
const provider = sdk.getProvider();
setMetaMaskProvider(provider);
}

// Call Profile SDK API to retrieve Hydra Access Token & Wallet userProfile
// Hydra Access Token will be used to fetch Infura API
const { accessToken, userProfile } = await authenticateAndAuthorize(VERCEL_ENV as string);
const { accessToken, userProfile } = await authenticateAndAuthorize(
VERCEL_ENV as string
);

const loginResponse = await (
await fetch(
Expand All @@ -168,7 +176,7 @@ const AuthModal = ({
headers: {
...REQUEST_PARAMS().headers,
hydra_token: accessToken,
token: 'true',
token: "true",
},
body: JSON.stringify({
profileId: userProfile.profileId,
Expand All @@ -189,7 +197,7 @@ const AuthModal = ({
step: data.step,
mmAuthSession: localStorage.getItem(AUTH_WALLET_SESSION_NAME),
walletPairing: data.pairing,
token: true
token: true,
})
).toString("base64");

Expand Down Expand Up @@ -239,8 +247,13 @@ const AuthModal = ({
setProjects(projects);
setOpen(false);
} catch (e: any) {
setStep(AUTH_LOGIN_STEP.CONNECTION_ERROR);
setOpen(true);
if (pathname.startsWith('/wallet/reference')) {
setStep(AUTH_LOGIN_STEP.CONNECTION_SUCCESS);
setOpen(true);
} else {
setStep(AUTH_LOGIN_STEP.CONNECTION_ERROR);
setOpen(true);
}
}
};

Expand Down
4 changes: 2 additions & 2 deletions src/components/ParserOpenRPC/AuthBox/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ interface AuthBoxProps {
}

export const AuthBox = ({ isMetamaskNetwork = false }: AuthBoxProps) => {
const { metaMaskConnectHandler, metaMaskWalletIdConnectHandler } = useContext(MetamaskProviderContext);
const { metaMaskWalletIdConnectHandler } = useContext(MetamaskProviderContext);
const connectHandler = () => {
trackClickForSegment({
eventName: "Connect wallet",
clickType: "Connect wallet",
userExperience: "B",
});
isMetamaskNetwork ? metaMaskConnectHandler() : metaMaskWalletIdConnectHandler();
metaMaskWalletIdConnectHandler();
};
return (
<div className={styles.msgWrapper}>
Expand Down
8 changes: 4 additions & 4 deletions src/components/ParserOpenRPC/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
import { AuthBox } from "@site/src/components/ParserOpenRPC/AuthBox";
import { MetamaskProviderContext } from "@site/src/theme/Root";
import ProjectsBox from "@site/src/components/ParserOpenRPC/ProjectsBox";
import { REF_PATH } from "@site/src/lib/constants";

interface ParserProps {
network: NETWORK_NAMES;
Expand All @@ -36,8 +37,6 @@ interface ParserOpenRPCContextProps {
export const ParserOpenRPCContext =
createContext<ParserOpenRPCContextProps | null>(null);

const REF_PATH = "/wallet/reference/new-reference";

export default function ParserOpenRPC({
network,
method,
Expand All @@ -52,8 +51,9 @@ export default function ParserOpenRPC({
const [isDrawerContentFixed, setIsDrawerContentFixed] = useState(false);
const [drawerLabel, setDrawerLabel] = useState(null);
const [isComplexTypeView, setIsComplexTypeView] = useState(false);
const { metaMaskAccount, metaMaskProvider } =
useContext(MetamaskProviderContext);
const { metaMaskAccount, metaMaskProvider } = useContext(
MetamaskProviderContext
);
const { colorMode } = useColorMode();
const openModal = () => {
setModalOpen(true);
Expand Down
6 changes: 3 additions & 3 deletions src/lib/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ export const DASHBOARD_URL = (DASHBOARD_PREVIEW_URL, VERCEL_ENV) => DASHBOARD_PR
? DASHBOARD_PREVIEW_URL
: VERCEL_ENV === "production"
? PROD_APP_URL
: VERCEL_ENV === "preview"
? STAGE_APP_URL
: DEV_APP_URL;
: STAGE_APP_URL;

export const REF_PATH = "/wallet/reference/new-reference";

const TEST_TRANSACTIONS = {
mainnet: {
Expand Down
18 changes: 9 additions & 9 deletions src/lib/siwsrp/auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,27 @@ type HydraEnv = {
};

const { AuthType, Env, getEnvUrls, JwtBearerAuth, Platform } = SDK;
let VERCEL_ENV = 'development'
let VERCEL_ENV: string
export const AUTH_WALLET_SESSION_NAME = "auth.wallet.session";
export const AUTH_WALLET_TOKEN = "auth.wallet.token";
export const AUTH_WALLET_PROJECTS = "auth.wallet.projects";

export const getHydraEnv = (): HydraEnv => {
const platform = Platform.INFURA;

// if (VERCEL_ENV === "production") {
if (VERCEL_ENV === "production") {
return {
...getEnvUrls(Env.PRD),
env: Env.PRD,
platform,
};
// } else {
// return {
// ...getEnvUrls(Env.DEV),
// env: Env.DEV,
// platform,
// };
// }
} else {
return {
...getEnvUrls(Env.DEV),
env: Env.DEV,
platform,
};
}
};

const storage: SDK.AuthStorageOptions = {
Expand Down
13 changes: 0 additions & 13 deletions src/theme/Root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ interface Project {
interface IMetamaskProviderContext {
projects: { [key: string]: Project };
setProjects: (arg: { [key: string]: Project }) => void;
metaMaskConnectHandler: () => Promise<void>;
metaMaskDisconnect: () => Promise<void>;
metaMaskWalletIdConnectHandler: () => Promise<void>;
userId: string | undefined;
Expand All @@ -63,7 +62,6 @@ interface IMetamaskProviderContext {
export const MetamaskProviderContext = createContext<IMetamaskProviderContext>({
projects: {},
setProjects: () => {},
metaMaskConnectHandler: () => new Promise(() => {}),
metaMaskDisconnect: () => new Promise(() => {}),
metaMaskWalletIdConnectHandler: () => new Promise(() => {}),
userId: undefined,
Expand Down Expand Up @@ -125,16 +123,6 @@ export const LoginProvider = ({ children }) => {
} catch (e) {}
};

const metaMaskConnectHandler = async () => {
try {
const accounts = await sdk.connect();
setMetaMaskAccount(accounts);
if (accounts && accounts.length > 0) {
setMetaMaskAccount(accounts[0]);
}
} catch (e) {}
};

useEffect(() => {
const provider = sdk?.getProvider();
setMetaMaskProvider(provider);
Expand Down Expand Up @@ -224,7 +212,6 @@ export const LoginProvider = ({ children }) => {
setMetaMaskAccount,
projects,
setProjects,
metaMaskConnectHandler,
metaMaskDisconnect,
metaMaskWalletIdConnectHandler,
userId,
Expand Down
Loading