Read4D #43
Open
Read4D #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n.b. there are lots of commits here, as I made a bit of a meal of the implementation details |
EdHone
reviewed
Jan 8, 2025
| transient_outputs = [] | ||
| executable = './read.exe' | ||
|
|
||
| @unittest.skipIf(os.environ.get('MVER', '') == 'XIOS/trunk@2252', |
There was a problem hiding this comment.
A comment here about why this is being skipped for r2252 would be useful
There was a problem hiding this comment.
there is a bug in XIOSr2252 which is causing problems with reading dimensionality from these 4D inputs
it's still not clear all of the conditions which lead to this, certainly some reads work, but this case fails.
it's a known error, and fixed in newer XIOS2 revisions
I've added a code comment detailing the failure mode within the code, as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exploring multi-dimensional read behaviour
this new example adds a 4D structured input file and simply reads data from that file into memory
This is designed to be extensible, enabling much larger files to be read, across multiple client and server ranks, and performance analyses undertaken