feat: support allocating IP with index from node chunk #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
reviewed
Oct 9, 2024
pkg/cni/types/types.go
Outdated
| if len(n.IPAM.RequestedIPs) > 0 { | ||
| return nil, fmt.Errorf("allocateIPWithIndex can't be used together with static IP request") | ||
| } | ||
| if n.IPAM.Features.AllocateDefaultGateway { |
There was a problem hiding this comment.
It looks like we will never reach this code. This condition is already handled on line 209
pkg/ipam-node/handlers/allocate.go
Outdated
| } | ||
|
|
||
| // IPOffsetBy returns the IP that is offseted by index from the given IP | ||
| func IPOffsetBy(ip net.IP, index int32) net.IP { |
There was a problem hiding this comment.
Let's use this one
nvidia-k8s-ipam/pkg/ip/cidr.go
Line 35 in 6649bfc
This feature enables us to allocate the IP that is offset by index from the start of the range allocated for a particular node using CNI args. It is useful when a particular workload that runs as DaemonSet wants to allocate always the same IP, even if it's recreated. Signed-off-by: Vasilis Remmas <[email protected]>
vasrem
force-pushed
the
feature/support-request-for-specific-ip-index-in-chunk
branch
from
cb88c3f
to
9d75e01
Compare
ykulazhenkov
approved these changes
Oct 10, 2024
vasrem
deleted the
feature/support-request-for-specific-ip-index-in-chunk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables us to allocate the IP that is offset by index from the start of the range allocated for a particular node using CNI args. It is useful when a particular workload that runs as DaemonSet wants to allocate always the same IP, even if it's recreated.