🛠️ [FIX] Fixed nrows and ncols arguments #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nrows arguments of GridLayout and ResponsiveGridLayout are now taken into account instead of always using the default value. Furthermore, the type of the ncols argument of ResponsiveGridLayout has been changed to object so that it accepts a dict with different values for each breakpoint according to the documentation. Signed-off-by: Léon Lazar <[email protected]>
IstvanM
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nrows arguments of GridLayout and ResponsiveGridLayout are now taken into account instead of always using the
default value. Furthermore, the type of the ncols argument of ResponsiveGridLayout has been changed to object so that it accepts a dict with different values for each breakpoint according to the documentation.
The program was tested solely for our own use cases, which might differ from yours.
Closes #8
Léon Lazar [email protected] on behalf of Mercedes-Benz Tech Innovation GmbH, Imprint
Licensed under MIT