Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17] Make slack message json format #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#17] Make slack message json format #19

wants to merge 2 commits into from

Conversation

cwJohnPark
Copy link
Collaborator

close #17

ksy90101
ksy90101 requested changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@ksy90101 ksy90101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 피드백 남겼습니다. 확인해주세요!

docker/mariadb/docker-compose.yml
image: adminer
restart: always
ports:
- 8082:8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 mariadb를 8080으로 띄우면 실제 서버는 몇번 포트로 띄우실 생각이실까요?

study-core/src/main/java/com/study/service/batch/ReviewMatchTasklet.java
String sendResult = slackService.sendMessage(
ReviewSlackMessage.makeReviewMatchingMessage(channelName, reviews));

log.info("Call Slack API result : {}", sendResult);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그 👍

study-slack-api/src/main/resources/application-slack.yml
@@ -0,0 +1,4 @@
slack:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이쪽부분은 일단 삭제 해주세요!

study-slack-api/src/main/java/com/study/service/slack/service/SlackService.java
@@ -16,12 +16,15 @@
@Slf4j
@Service
public class SlackService {
private static final String SLACK_API_BASE_URL = "https://slack.com/api";
private static final String SLACK_API_BASE_URL = "https://hooks.slack.com";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어? 원래 하던 방식으로 안하신 이유가 있나요?
봇으로 관리하는게 더 좋을거 같은데 왜 hooks을 쓰셨나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksy90101 ksy90101 ksy90101 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Slack message json format
2 participants
@cwJohnPark @ksy90101