Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aspectj dependency for jcabi-maven-plugin #5

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

rdenarie
Copy link
Member

jcabi-maven-plugin:0.14 use org.aspectj:aspectjtools:1.8.6

This version can have problem with java8 and later for weaving class, throwing exception like

org.aspectj.apache.bcel.classfile.ClassFormatException: File: 'module-info.class': Invalid byte tag in constant pool: 19

As explained in this jcabi issue jcabi/jcabi-maven-plugin#58, we update aspectjtools dependency to 1.9.1 for jcabi maven plugin only

This version can have problem with java8 and later for weaving class, throwing exception like

	org.aspectj.apache.bcel.classfile.ClassFormatException: File: 'module-info.class': Invalid byte tag in constant pool: 19

As explained in this jcabi issue jcabi/jcabi-maven-plugin#58, we update aspectjtools dependency to 1.9.1 for jcabi maven plugin only
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdenarie rdenarie merged commit 5af78a7 into develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants