Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mbedtls_dev to mbedtls_framework in the framework repo #15

Merged
merged 10,000 commits into from
May 27, 2024

Conversation

davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented May 3, 2024

Fixes #13

See also Mbed-TLS/mbedtls#9094

Move files from mbedtls_dev into mbedtls_framework while preserving their histories. Do this by taking the mbedtls repository and deleting all files except the ones we want to move, then merging this branch into the mbedtls-framework repository.

This operation was automated via the script in Mbed-TLS/mbedtls-docs#145

ronald-cron-arm and others added 30 commits March 15, 2024 10:46
Add testing for concurrently loading/using/destroying the same key
Expand MSVC to Visual Studio and announce the moving of the solution
files.

Signed-off-by: Bence Szépkúti <[email protected]>
All supported versions of Visual Studio support AESNI, so drop the
version number.

Signed-off-by: Bence Szépkúti <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
…ompat-tests

TLS 1.3: Resumption and early data compatibility tests
Test the behavior of mbedtls_pk_get_psa_attributes() and
mbedtls_pk_import_into_psa() with respect to lifetime. In particular, test
that they work with persistent keys as documented.

Test cases generated by the following script:
```
for old in [('transparent', '0:0:1'),
            ('opaque volatile [export]', '1:0:1'),
            ('opaque volatile [copy]', '1:0:0'),
            ('opaque persistent [export]', '1:1:1'),
            ('opaque persistent [copy]', '1:1:0')]:
    for to_public in [('pair', '0'),
                      ('public', '1')]:
        for to_persistent in [('volatile', '0'),
                              ('persistent', '1')]:
            depends = ('\ndepends_on:MBEDTLS_USE_PSA_CRYPTO'
                       if old[0].startswith('opaque')
                       else '')
            print(f"""\
PSA import into PSA: {old[0]} -> {to_persistent[0]} {to_public[0]}{depends}
pk_import_into_psa_lifetime:{old[1]}:{to_public[1]}:{to_persistent[1]}
""")
```

Signed-off-by: Gilles Peskine <[email protected]>
Drop Support for MSVC 2013, 2015 and Arm Compiler 5
Signed-off-by: Paul Elliott <[email protected]>
…-nego-testing

TLS: Improve server version negotiation testing
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
…eiving-early-data

Check ALPN when receiving early data
Catch potential invalid calls to init.

Signed-off-by: Paul Elliott <[email protected]>
TLS 1.3: Documentation update for 3.6 release
Adds missing transition and italicises internal functions

Signed-off-by: Ryan Everett <[email protected]>
A few typo fixes, extrapolations and extra details.

Signed-off-by: Ryan Everett <[email protected]>
…est-lifetime

pk_import_into_psa: test persistent keys
Signed-off-by: Dave Rodgman <[email protected]>
Undefined reference to mbedtls_md_error_from_psa() function
@davidhorstmann-arm davidhorstmann-arm added needs-work needs-preceding-pr Requires another PR to be merged first labels May 3, 2024
@davidhorstmann-arm davidhorstmann-arm changed the title Move mbedtls_dev to mbedtls_framework in the framework module Move mbedtls_dev to mbedtls_framework in the framework repo May 3, 2024
@davidhorstmann-arm davidhorstmann-arm force-pushed the dev/davidhorstmann-arm/add-mbedtls-framework-module branch from 435c1a5 to 7c58bc6 Compare May 3, 2024 13:56
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon and removed needs-work needs-preceding-pr Requires another PR to be merged first labels May 3, 2024
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in association to #9094.

@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label May 13, 2024
Copy link
Contributor

@bensze01 bensze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@bensze01 bensze01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels May 27, 2024
@ronald-cron-arm ronald-cron-arm merged commit e156a8e into main May 27, 2024
1 check passed
davidhorstmann-arm pushed a commit that referenced this pull request May 29, 2024
davidhorstmann-arm pushed a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon
Projects
Development

Successfully merging this pull request may close these issues.

Move mbedtls_dev to mbedtls-framework