Add gesture locking #81

ghost · 2016-03-09T05:44:25Z

Hi Max,

As discussed on XDA, please check this pull request. Some points to note are

In translated strings.xml, I have added the untranslated strings directly, to allow compilation.
I have used a non AOSP GestureOverlayView.java because the AOSP version clears the gesture after it is drawn.

You may want to refactor some stuff as per your preferences, but I have tried to do the best I could. Thanks for your time.

Maxr1998 · 2016-03-09T08:06:10Z

Very clean code, thanks! I'll look through it in detail in the next days, depending how much time I have; then I'll merge and reformat it a little to my needs :)

ghost · 2016-03-09T16:56:36Z

You may also want to look at the theme manager's application on the Gesture View, I did not touch it at all.

Maxr1998 · 2016-03-09T18:34:28Z

@Rijul-Ahuja Theme manager isn't implemented, tbh.. So you don't have to change anything about it ;)

ghost · 2016-03-18T07:59:24Z

Max, just thought I should mention this, the gesture file isn't encrypted at all, unlike the other modes. If you figure out a way to encrypt the gesture (that is, not just the name, but the actual gesture itself), do let me know, I will implement it in the gesture lockscreen module.

Maxr1998 · 2016-03-18T14:55:42Z

Thanks! I'll see if I can do it on my own :) I will work on fixing a few things in MaxLock now, and then I'll merge your PR.

Maxr1998 · 2016-03-20T21:22:02Z

app/src/main/java/de/Maxr1998/xposed/maxlock/ui/lockscreen/LockView.java

+            else
+                mPassword = getPreferencesKeys(getContext()).getString(Common.KEY_PREFERENCE, "");
+        }
+        Log.e(LockView.class.getName(), mPassword);


Could you remove logging th password nd locking type, please?

Apologies, that was for debugging. Right now I've exams, so I'll remove it
after ~13 hours (two exams today).

Oh, no prob. It can wait until later/tomorrow. Good luck with your exams!

Maxr1998 · 2016-03-20T21:24:47Z

Could you take a look at my line note? Also, could you remove the alternate translations? I think the translators should pick the new strings out on their own.

Maxr1998 · 2016-03-21T20:08:31Z

Perfect, thanks!

Maxr1998 · 2016-03-25T19:08:20Z

I decided I won't merge this before next release. I want to have the new release as stable as possible, and out as soon as possible..

ghost · 2016-03-25T19:15:30Z

Sure, it is your app. Just put up a comment here when you are done so I get to know.
PS : Are your translators volunteers you found, or did they find you?

Maxr1998 · 2016-03-25T19:26:33Z

Of course. I will just tell here.
Actually, both. Many are just users who asked to translate, but I also asked one or two of my users to do the translations.
BTW, it seems I broke this PR with my last changes (sorry!). Could you take a look at it?

ghost · 2016-03-25T19:40:28Z

Can you tell me how to look at it? I am not well versed with git. A general idea of what to Google will do, too.

Maxr1998 · 2016-03-25T19:51:34Z

Well, you have to adapt my changes to your proposes. So you have to pull my updates from my git and then fix the conflicts. I can also do it, but it would be very nice if you could do it :)

Maxr1998 · 2016-04-13T19:07:11Z

@Rijul-Ahuja
Would it be ok for you if I merged this manually? You won't be listed as contributor in the GitHub stats then, but I'll include you in the about screen as sole creator of Gesture lockscreen.

Maxr1998 · 2016-04-13T19:07:48Z

Also, could you tell me which files you took from the AOSP? Only the ones with the copyright?

Maxr1998 · 2016-04-13T19:09:11Z

And another question, what is the reason for first extending LockGestureView from GestureOverlayView, then GestureActivityView from LockGestureView?
Can't I just merge the non-AOSP views?

ghost · 2016-04-14T14:34:39Z

Sorry, I totally forgot about this commit.

Manual works, I don't mind. If there is a link, please link to fb.com/rijul.ahuja
No files from AOSP, they are from Temasek. temasek/android_frameworks_base@d89f57b and temasek/android_packages_apps_Settings@8fea9e7
LockGestureView is used in the GestureSetupFragment and GestureActivityView is used in the lock activity, because they use different methods of authentication. (GestureSetupFragment saves in the gesture file, while the GestureActivityView calls the parent activity to match the gesture, like you do with the knock code and stuff, using an authenticationSucceededListener).

Can't I just merge the non-AOSP views?
I don't understand what this means.

Maxr1998 · 2016-04-15T15:12:25Z

Sure, will add that link.
Thanks, then I'll mention them in the credits.
Ah, I see, silly me. Then of course you need different views.

Forget about my other request, basically wanted to merge fragment and activity code, which doesn't work.

ghost · 2016-05-06T19:11:23Z

Any movement on this, Max?

Maxr1998 · 2016-05-06T19:55:32Z

Yeah, I will add it next when I find time for MaxLock again

Gestures!!!!!

37e9107

Maxr1998 reviewed Mar 20, 2016
View reviewed changes

rijul-ahuja added 6 commits March 22, 2016 00:28

remove Log lines

db786a7

remove untranslated strings from translated files

f7d3fc7

relocate gesture strings, remove extra lines in translated files

59509d2

add a translatable string

79cc4f9

remove app gesture if cancelled

ae60a32

add a translatable string in strings.xml

0574e4a

Maxr1998 self-assigned this Mar 21, 2016

Maxr1998 force-pushed the master branch 2 times, most recently from 4b492d0 to b50d2ca Compare March 18, 2017 12:55

Maxr1998 force-pushed the master branch 3 times, most recently from 502e98b to 059f373 Compare April 21, 2017 21:49

Maxr1998 force-pushed the master branch from 643bae2 to 7dacce8 Compare May 17, 2017 15:12

Maxr1998 force-pushed the master branch from e77a6bf to a98998b Compare June 16, 2017 22:56

Maxr1998 added this to the 7.1 milestone Nov 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add gesture locking #81

Add gesture locking #81

ghost commented Mar 9, 2016

Maxr1998 commented Mar 9, 2016

ghost commented Mar 9, 2016

Maxr1998 commented Mar 9, 2016

ghost commented Mar 18, 2016

Maxr1998 commented Mar 18, 2016

Maxr1998 Mar 20, 2016

ghost Mar 20, 2016

Maxr1998 Mar 20, 2016

Maxr1998 commented Mar 20, 2016

Maxr1998 commented Mar 21, 2016

Maxr1998 commented Mar 25, 2016

ghost commented Mar 25, 2016

Maxr1998 commented Mar 25, 2016

ghost commented Mar 25, 2016

Maxr1998 commented Mar 25, 2016

Maxr1998 commented Apr 13, 2016

Maxr1998 commented Apr 13, 2016

Maxr1998 commented Apr 13, 2016

ghost commented Apr 14, 2016

Maxr1998 commented Apr 15, 2016

ghost commented May 6, 2016

Maxr1998 commented May 6, 2016 •

edited

Loading

Add gesture locking #81

Are you sure you want to change the base?

Add gesture locking #81

Conversation

ghost commented Mar 9, 2016

Maxr1998 commented Mar 9, 2016

ghost commented Mar 9, 2016

Maxr1998 commented Mar 9, 2016

ghost commented Mar 18, 2016

Maxr1998 commented Mar 18, 2016

Maxr1998 Mar 20, 2016

Choose a reason for hiding this comment

ghost Mar 20, 2016

Choose a reason for hiding this comment

Maxr1998 Mar 20, 2016

Choose a reason for hiding this comment

Maxr1998 commented Mar 20, 2016

Maxr1998 commented Mar 21, 2016

Maxr1998 commented Mar 25, 2016

ghost commented Mar 25, 2016

Maxr1998 commented Mar 25, 2016

ghost commented Mar 25, 2016

Maxr1998 commented Mar 25, 2016

Maxr1998 commented Apr 13, 2016

Maxr1998 commented Apr 13, 2016

Maxr1998 commented Apr 13, 2016

ghost commented Apr 14, 2016

Maxr1998 commented Apr 15, 2016

ghost commented May 6, 2016

Maxr1998 commented May 6, 2016 • edited Loading

Maxr1998 commented May 6, 2016 •

edited

Loading