Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable escaping and unescaping of level parts #13

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Mar 31, 2022

Description

It is now possible to have arbitrary buffers as levels. So if the buffer has 0x00 or the separator byte, it is no longer a problem. We now automatically escape the separator bytes, and we also automatically escape any escaping byte too 0x5c.

Issues Fixed

Tasks

  • 1. Added escapeLevel
  • 2. Added unescapeLevel
  • 3. Updated parseKey to properly handle where 0x00 or 0x5c may appear within the level part
  • 4. Removed ErrorDBLevelSep and checkSepLevelPath and checkSepKeyPath.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant