Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset parser #342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Offset parser #342

wants to merge 2 commits into from

Conversation

r4v3n6101
Copy link

@r4v3n6101 r4v3n6101 commented Mar 8, 2022

Hello! Previously, I asked to make an offset function parsing data located by some offset. Finally, I've found time to do this one. But we should discuss the feature because look_ahead(skip_count(count).with(parser)) does same thing as offset. Does the combine really need the new parser? If so then it closes #337.

@r4v3n6101
Copy link
Author

First, my thanks to @Marwes for approving first PR of mine.
Second topic I'd like to discuss is naming of this parser. offset seems to me as very abstract and general word: it may be shadowed with everything - other function named offset or some random variable. What about by_offset or parse_by_offset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about offset into some data?
1 participant