Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 No SDCARD_SORT_ALPHA on Creality CR-6 SE (for now) #1071

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jun 26, 2024

Description

While running the build_all_examples script, this config would not build because SDCARD_SORT_ALPHA was enabled:

#error "SDCARD_SORT_ALPHA requires an LCD that supports it. (It doesn't apply to M20, etc.)"

I see the upstream PR (MarlinFirmware/Marlin#19958) uses this config and is passing upstream CI tests, but it's been open for four years and has caused CI to fail in this (Configurations) repo since we've enabled CI testing on all PRs. If CR-6 SE support is ever merged, we can enable SDCARD_SORT_ALPHA on this config again.

Benefits

Config now builds.

Related Issues

@thisiskeithb thisiskeithb changed the title 🔧 No SDCARD_SORT_ALPHA on Creality CR-6 SE 🔧 No SDCARD_SORT_ALPHA on Creality CR-6 SE (for now) Jun 26, 2024
@thinkyhead
Copy link
Member

thinkyhead commented Jun 27, 2024

I recently sent my CR-6 SE to my former roommate and helpful friend Luu Lac, and he informs me that the firmware provided by Creality is terrible, so it would be great to get that PR completed with the display/controller support integrated as neatly as we can according to the latest paradigm. In order to make future integration of custom controllers easier, I've started on work to add an ExtUI layer to Ender-3 V2 ProUI. It demonstrates the possibility to integrate more new display/controllers by expanding on the ExtUI methods and replacing special case callbacks with additional ExtUI callbacks.

@thisiskeithb
Copy link
Member Author

I recently sent my CR-6 SE to my former roommate and helpful friend Luu Lac, and he informs me that the firmware provided by Creality is terrible, so it would be great to get that PR completed with the display/controller support integrated as neatly as we can according to the latest paradigm. In order to make future integration of custom controllers easier, I've started on work to add an ExtUI layer to Ender-3 V2 ProUI. It demonstrates the possibility to integrate more new display/controllers by expanding on the ExtUI methods and replacing special case callbacks with additional ExtUI callbacks.

Awesome!

Other than the Ender-5 S1 and CR-6 SE configs needing upstream support, we're almost able to build every config hosted here. Ideally, I'd like to enable CI on direct commits once we reach 100% so it'll be faster / easier to tell when something breaks.

@thinkyhead thinkyhead merged commit 3ef3ffd into MarlinFirmware:import-2.1.x Jul 11, 2024
1 check passed
@thisiskeithb thisiskeithb deleted the pr/fix_cr-6_se_build branch July 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants