Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HICTOP 3DP-17 #1064

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

Gadgeteering
Copy link
Contributor

Description

Add configuration files for HICTOP 3DP-17 printer

@Gadgeteering
Copy link
Contributor Author

Gadgeteering commented Jun 9, 2024

Built and tested on my HICTOP 3DP-17

@thinkyhead
Copy link
Member

Thanks for the submission! New configurations must be based on the default configurations from import-2.1.x for inclusion in the next release. The configurations in this PR are targeted to an older version of Marlin, so they will need to be updated to the current version, 02010300 .

@thinkyhead
Copy link
Member

I went ahead and applied the needed updates. Please check to make sure they still work as intended and have all the same changes. One quick way to see all the changes in isolation is to replace the Hictop configs with the default configs, then use GitHub Desktop to view the differences.

@Gadgeteering
Copy link
Contributor Author

line 1601 should read

#define NOZZLE_TO_PROBE_OFFSET { 10, 50, -1} 

I have tried to build the firmware but get error for the code between lines 3212->3215

//#define DGUS_LCD_UI ORIGIN
#if DGUS_UI_IS(MKS)
  #define USE_MKS_GREEN_UI
#elif DGUS_UI_IS(IA_CREALITY)

I am using PlaformIO in visual studio code to build the firmware

@thisiskeithb
Copy link
Member

I have tried to build the firmware but get error for the code between lines 3212->3215

What's the error? Make sure you're using the latest bugfix-2.1.x.

All changed configs in a PR are built and this PR passed:

image

@Gadgeteering
Copy link
Contributor Author

Thanks for your advice, build and tested on my 3D printer

@thisiskeithb
Copy link
Member

Thanks for your advice, build and tested on my 3D printer

I assume you closed this PR on accident, so I’ve reopened it.

How’d testing go?

@Gadgeteering
Copy link
Contributor Author

Tested and works

@thinkyhead thinkyhead force-pushed the import-2.1.x branch 17 times, most recently from 4f52bae to 17c4846 Compare September 18, 2024 17:21
@Emma2109

This comment was marked as off-topic.

@thinkyhead thinkyhead merged commit e55355a into MarlinFirmware:import-2.1.x Sep 27, 2024
1 check passed
@Emma2109

This comment was marked as off-topic.

@Emma2109

This comment was marked as off-topic.

rngkll pushed a commit to rngkll/Configurations that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants