-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HICTOP 3DP-17 #1064
Added HICTOP 3DP-17 #1064
Conversation
Built and tested on my HICTOP 3DP-17 |
Thanks for the submission! New configurations must be based on the default configurations from |
I went ahead and applied the needed updates. Please check to make sure they still work as intended and have all the same changes. One quick way to see all the changes in isolation is to replace the Hictop configs with the default configs, then use GitHub Desktop to view the differences. |
line 1601 should read #define NOZZLE_TO_PROBE_OFFSET { 10, 50, -1} I have tried to build the firmware but get error for the code between lines 3212->3215 //#define DGUS_LCD_UI ORIGIN
#if DGUS_UI_IS(MKS)
#define USE_MKS_GREEN_UI
#elif DGUS_UI_IS(IA_CREALITY) I am using PlaformIO in visual studio code to build the firmware |
What's the error? Make sure you're using the latest All changed configs in a PR are built and this PR passed: |
Thanks for your advice, build and tested on my 3D printer |
I assume you closed this PR on accident, so I’ve reopened it. How’d testing go? |
Tested and works |
fd6f162
to
e97fb18
Compare
782bc68
to
5bea54f
Compare
4f52bae
to
17c4846
Compare
Description
Add configuration files for HICTOP 3DP-17 printer