Add API POST /robotframework/run #37
Conversation
|
Wow, that's great. It's exactly what I need. Thank you very much |
| @@ -54,7 +54,7 @@ async def run_robot_and_wait(executor: Executor, func, args=[], kwargs={}): | |||
| ) | |||
|
|
|||
|
|
|||
| @router.get("/run/all", tags=["execution"]) | |||
| @router.get("/run/all", tags=["execution"], deprecated=True) | |||
There was a problem hiding this comment.
I would not like to deprecate the GET endpoint. With POST we always need a body which requires a bit logistics on the client side. GET is simply calling an URL.
I know it is only convenience and debatable if GET is meant for triggering an action. But it was very useful for me when hosting robot-werservice in Google Cloud Run.
I would like to keep GET and add the POST endpoint
remi-picard
force-pushed
the
api-run
branch
2 times, most recently
from
8c151ba to
e700544
Compare
Ok, no problem, I remove the deprecation changes. |
| import asyncio | ||
| import multiprocessing as mp | ||
| from concurrent.futures import Executor | ||
| from typing import Annotated |
There was a problem hiding this comment.
The import of Annotated seems to break with Python < 3.10
I am fine with dropping support for Python 3.7, since it is end-of-lie. I am not so sure though about dropping support for 3.8 and 3.9.
Can we make this somehow compatible with 3.8?
There was a problem hiding this comment.
You are right, there are some incompatibilities with Python < 3.10.
For example, I have to change import typing to typing_extensions (https://fastapi.tiangolo.com/python-types/#__tabbed_8_2)
I will try to fix 3.8 and 3.9.
There was a problem hiding this comment.
It is OK, I also change | with Optional (https://fastapi.tiangolo.com/python-types/#using-union-or-optional)
FastAPI is really well documentated !
remi-picard
force-pushed
the
api-run
branch
5 times, most recently
from
294f215 to
244461b
Compare
I suggest to add a new generic API POST endpoint to handle all possible robot CLI options (running test, task, suite... or overloading variables or changing loglevel... eventualy all possibles robot options).
Execution can be synchronous or asynchronous.
For example :
Options implemented (Swagger Schema) :
Examples in Swagger :
Old execution GET API could be deprecated :
