Fix overloading config and missing id in response

[remi-picard]

It was impossible to overload the config of the server.

I run the server on my local machines (Windows and MacOs) with options :

# taskfolder not overloaded
python -m RobotFrameworkService.main -p 5003 -t path_to_my_taskfolder
# variablefiles not overloaded
python -m RobotFrameworkService.main -p 5003 -V examples\environment.py

In RobotFrameworkService/routers/robotframework.py : RFS_Config().cmd_args is always DefaultConfig

The fix is to move up the call of config=RFS_Config().cmd_args in the async router method. I imagine that coroutines like _start_specific_robot_task are valued before execution and so they get the default value of RFS_Config.

There is another fix, in a second commit, for returning the id of test run.

[Noordsestern]

Looks good! I only have basically 2 questions about design changes. but overall this looks like an improvement. Thank you!

[Noordsestern]

Why do we make variables a mandatory argument?

If we make it mandatory, we can remove the following 2 lines, too and demand variables to at least an empty list.

[remi-picard]

You are right : variables is always None. I will remove variables from _start_all_robot_tasks.

[remi-picard]

I have pushed the changes

[Noordsestern]

same as above, marked for later tracability: Why do we make variables a mandatory argument?

[remi-picard]

This time, variables is always passed with _start_specific_robot_suite method. I think it should be mandatory.

Examples :

@router.get("/run/suite/{suite}", tags=["execution"])
async def run_suite(suite, request: Request):
    #...
    variables = RequestHelper.parse_variables_from_query(request)
    #...
    response = await run_robot_and_wait(
        request.app.state.executor,
        func=_start_specific_robot_suite,
        args=[id, suite, variables, config],
    )

We can remove the following 2 lines :

    if variables is None:
        variables = []

[remi-picard]

I have pushed the changes

[Noordsestern]

same as above, marked for later tracability: Why do we make variables a mandatory argument?

[remi-picard]

variables is always passed with _start_specific_robot_task method. I think it should be mandatory.

We can remove the following 2 lines :

    if variables is None:
        variables = []

[remi-picard]

I have pushed the changes

[Noordsestern]

Looks good! I agree with you on the suggested changes about the variables parameter and the obsolete lines.

[Noordsestern]

LGTM