Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows build, add exit from app menu #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jafrado
Copy link

@jafrado jafrado commented Feb 17, 2020

No description provided.

jfd added 2 commits February 17, 2020 15:04
…ew for camera view angle (front, top, right/left and birds eye perspective)
@jafrado
Copy link
Author

jafrado commented Dec 8, 2022

@MarkMuth - please have a look, I added rendering the image in the dataset as well as changing the view on the 3D Point cloud. You'll find this very useful for testing. Of course I also fixed the Windows build (added usleep).

@MarkMuth
Copy link
Owner

@jafrado Thanks for your interest in this project. I would very much like to merge your changes, but I see two problems here:

  1. Your Pull Request looks like it's not based on the latest version of the master branch.
  2. The fix for Windows seems to break the Linux build. I recommend to open a second PR for the Windows build and would like to have it in a separate branch as long as compiling for Windows and Linux is not possible from the same branch. Since I cannot test the Windows build myself, I would also like you to provide build instructions in the documentation directory as was done for Ubuntu 20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants