Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue-Jest dev Dependency for Vue Components Package #2565

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gerteck
Copy link
Contributor

@gerteck gerteck commented Jul 29, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

The dependency [email protected] is no longer supported. Let's update
to the supported vue-jest, @vue/vue2-jest@27

Anything you'd like to highlight/discuss:

When I was trying to update the node version, I faced errors installing the vue-jest dependency using Node v20, due to deasync sub-dependency, leading me to investigate.

  • similar to: https://github.com/vuejs/vue-jest/issues/403
  • https://github.com/snowdreamtech/vue-element-admin1/issues/2

As per https://github.com/vuejs/vue-jest,
since we are using Vue2, Jest@27, the updated package should be @vue/vue2-jest@27. Current dependency [email protected] no longer supported, prone to bugs.

image

Goal: Maintain the code, enable update of node version later on.

Opened separate PR for commit clarity. Please help to check as I'm not* entirely familiar with vue-jest as of yet, will double check again.

*Edit: Should fix #2496

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Update vue-jest dev dependency

[email protected] is no longer supported. Let's update
to the supported vue-jest, @vue/vue2-jest@27


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

[email protected] is no longer supported. Let's update
to the supported vue-jest, @vue/vue2-jest
@gerteck
Copy link
Contributor Author

gerteck commented Jul 30, 2024

For reference:

  • deasync is a dependency of vue-jest, which is causing an error in the setup process npm run setup or npm install while using Node v20.
  • Further investigation shows [email protected] is no longer maintained, and should be upgraded to either [email protected] or vue/vue2-jest@27 etc. to support later versions of Node

image

image

@gerteck
Copy link
Contributor Author

gerteck commented Jul 30, 2024

I believe it is related to #2496 as well, and should resolve the issue (needs further testing), since it does away entirely with the problematic deasync dependency causing the issue.

@Tim-Siu
Copy link
Contributor

Tim-Siu commented Aug 2, 2024

I believe it is related to #2496 as well, and should resolve the issue (needs further testing), since it does away entirely with the problematic deasync dependency causing the issue.

I tested npm install in Python 3.12, Node v20 and there was no error nor warning. I think this Pull Request will solve #2496.

Copy link
Contributor

@Tim-Siu Tim-Siu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on identifying and addressing this issue proactively!. Updating from [email protected] to @vue/vue2-jest@27 is a important step to ensure ongoing support and compatibility with newer Node versions. This update should resolve the installation issues related to the deasync sub-dependency, particularly when using Node v20.

The modifications to jest.config.js and package.json are appropriate and align with the stated goals. Updating related dependencies like @babel/preset-env and @vue/test-utils helps maintain compatibility.

This change should fix issue #2496 and improve the project's ability to work with more recent Node versions.

@Tim-Siu Tim-Siu merged commit bac8391 into MarkBind:master Aug 9, 2024
14 checks passed
@github-actions github-actions bot added the r.Minor Version resolver: increment by 0.1.0 label Aug 9, 2024
@gerteck gerteck mentioned this pull request Aug 18, 2024
30 tasks
@tlylt tlylt added r.Patch Version resolver: increment by 0.0.1 and removed r.Minor Version resolver: increment by 0.1.0 labels Sep 7, 2024
@gerteck gerteck mentioned this pull request Sep 11, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: Node LTS (v20) and python 3.12 does not work on MarkBind install
3 participants