Update Vue-Jest dev Dependency for Vue Components Package #2565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
The dependency
[email protected]
is no longer supported. Let's updateto the supported vue-jest,
@vue/vue2-jest@27
Anything you'd like to highlight/discuss:
When I was trying to update the node version, I faced errors installing the vue-jest dependency using Node v20, due to deasync sub-dependency, leading me to investigate.
https://github.com/vuejs/vue-jest/issues/403
https://github.com/snowdreamtech/vue-element-admin1/issues/2
As per https://github.com/vuejs/vue-jest,
since we are using Vue2, Jest@27, the updated package should be
@vue/vue2-jest@27
. Current dependency[email protected]
no longer supported, prone to bugs.Goal: Maintain the code, enable update of node version later on.
Opened separate PR for commit clarity. Please help to check as I'm not* entirely familiar with vue-jest as of yet, will double check again.
*Edit: Should fix #2496
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Update vue-jest dev dependency
[email protected]
is no longer supported. Let's updateto the supported vue-jest,
@vue/vue2-jest@27
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):