-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styling issue in Dismissible boxes #2564
Conversation
Fix styling issue for .dismissible-box .btn-close where global bootstrap css no longer applied to component with changed classname
Just a note, the testcases added previously don't seem to be able detect this styling regression, either for the close button in the modal, nor this close button for the dismissible box. Additionally, see #2558 comments for more detailed explanation of cause of bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Pull Request is very clear and brought the disired properties from bootstrap.min.css
and alert-dismissible
back to the custom wrapper alert-dismissible-box
. It solved the bug introduced in #2487.
I checked the issue of concern and it is now fixed. As the added css properties are from bootstrap.min.css
and no additional changes have been brought in, I think the PR is safe to merge.
Could you help confirm if #2473 is not affected by this change? As for the test failing to catch this...yes the existing ones may not be able to capture the change in target CSS values for the components, which seems to be the source of many UI positioning related bugs...possibly an area to look into to improve our test capabilities. |
Yeap! Here's a screenshot of my visual test, using minimal reproducible examples: |
Thanks! Will double check later today:) |
Fix styling issue for .dismissible-box .btn-close
where global bootstrap css no longer applied to
component with changed classname
What is the purpose of this pull request?
Fixes #2558
Overview of changes:
Changes in #2487 of class name of body wrapper from
alert-dismissible
toalert-dismissible-box
caused global bootstrap css styles on.alert-dimissible .btn-close
to lose effect, causing this bug.Added back css styles based on bootstrap css to restore original styling.
Testing instructions:
markbind serve -d
.Proposed commit message: (wrap lines at 72 characters)
Fix dismissible-box styling issue
Changes in #2487 renamed the class from
alert-dismissible
toalert-dismissible-box
, causing Bootstrap CSS styles on.alert-dismissible .btn-close
to lose effect.This commit restores the original styling by adding back
the necessary CSS styles to
.alert-dismissible-box .btn-close
.Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):