Move buggy bootstrap-icons dependency to core/package.json #2539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Addresses #2538
Overview of changes:
Moving of the dependency. The file packages/core/package.json is also where the other icon dependencies live.
Anything you'd like to highlight/discuss:
See comments on issue. Also, testing may be misleading CI passing, local passing even with the erroneous code, and some websites deploying fine on 5.5.0 (eg markbind website).
Also, I have no idea why that last bracket is marked as a change. It looks the same to me???
Testing instructions:
Ideas on how else to test appreciated.
Reproducing issue notes:
Testing this PR:
Proposed commit message: (wrap lines at 72 characters)
Move buggy bootstrap-icons dependency to core/package.json
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):