-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for logger output when component attributes are overridden by slots #2525
Merged
itsyme
merged 15 commits into
MarkBind:master
from
luminousleek:add-nodeprocessor-tests
Apr 25, 2024
Merged
Add tests for logger output when component attributes are overridden by slots #2525
itsyme
merged 15 commits into
MarkBind:master
from
luminousleek:add-nodeprocessor-tests
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yucheng11122017
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the detailed work @luminousleek
itsyme
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks adding more tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #2476
Overview of changes:
box
,modal
,tooltip
,tab
andtab-group
scroll-top-button
anda-point
content
attribute overridessrc
attribute inpopover
Anything you'd like to highlight/discuss:
Inconsistent Test Inputs across Components
For some components, the test inputs test for all attributes at once to see if they are being checked properly, e.g.
where both the
header
andalt
attributes are tested at the same time. However, for other components e.g.box
, these are tested one at a time:Do let me know which one you prefer and I will refactor accordingly. Personally I don't see a real need to separate the attributes for the tests.
Other things
Documentation for which attributes are able to be overridden will be done in a separate PR.
Lastly, sorry for the long PR :(
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add tests for logger output when overriding attributes
Currently only certain components are tested for logger warnings
when their attributes are overridden by slots.
Let's add tests for the remaining attributes and components, as well
as add missing tests for the components which do not currently
have tests.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):