Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stray space before popover and tooltip #2486

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

yiwen101
Copy link
Contributor

@yiwen101 yiwen101 commented Mar 30, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Resolve #2419, modified vue(modification made at minimal scope via trial and error) and add test;
Credit to @kaixin-hc for investigating the cause of the bug.

Anything you'd like to highlight/discuss:

Testing instructions:
Test with markbind serve -d

Proposed commit message: (wrap lines at 72 characters)
Fix stray space before popover and tooltip


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.11%. Comparing base (cab80b7) to head (cbe3ede).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2486   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files         124      124           
  Lines        5355     5355           
  Branches     1152     1152           
=======================================
  Hits         2737     2737           
  Misses       2328     2328           
  Partials      290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yiwen101 yiwen101 marked this pull request as draft March 30, 2024 15:31
@yiwen101 yiwen101 marked this pull request as ready for review March 30, 2024 15:51
Copy link
Contributor

@EltonGohJH EltonGohJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Good job in finding a solution to this bug.
I am just thinking whether we can do better as I think that future devs may be confuse why there is a comment there. Maybe gitblame will be enough but I am thinking whether we can do more.

@tlylt
Copy link
Contributor

tlylt commented Apr 1, 2024

as I think that future devs may be confuse why there is a comment there

I agree, not obvious and could be accidentally deleted in the future. @yiwen101 could you note the reason inside the comment pls?

@yiwen101
Copy link
Contributor Author

yiwen101 commented Apr 3, 2024

@tlylt @EltonGohJH
Thank you for the valuable suggestions. I have improve the comment.

Copy link
Contributor

@kaixin-hc kaixin-hc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - merging!

@kaixin-hc kaixin-hc merged commit c268733 into MarkBind:master Apr 4, 2024
9 checks passed
Copy link

github-actions bot commented Apr 4, 2024

@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.

@kaixin-hc kaixin-hc added the r.Patch Version resolver: increment by 0.0.1 label Apr 4, 2024
@kaixin-hc kaixin-hc added this to the v5.4.1 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips seem to add an extra space in front
4 participants