-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizing list icons: give a way to apply to current item only #2454
Merged
yucheng11122017
merged 88 commits into
MarkBind:master
from
KevinEyo1:2405-customize-list-icon
Apr 7, 2024
Merged
Changes from 46 commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
22853a6
Update templates and add ab3 template
KevinEyo1 e76fb5f
Remove ab3 template folder
KevinEyo1 e3c1138
Update files
KevinEyo1 ef96316
Remove unneeded changes
KevinEyo1 5444909
a
KevinEyo1 a4a4d72
Revert test changes
KevinEyo1 ea3aca7
Merge branch 'MarkBind:master' into master
KevinEyo1 a7f1a81
Replace ab3 with project
KevinEyo1 d926774
Remove ab3 package
KevinEyo1 c21eefb
Add project template folder
KevinEyo1 c0f79a2
Merge branch 'MarkBind:master' into master
KevinEyo1 c0207fd
Update project template
KevinEyo1 b6ed49a
Merge branch 'MarkBind:master' into 2384-markbind-template-project
KevinEyo1 e40a454
Update template file
KevinEyo1 8fd7b50
Remove unused gemfile.lock
KevinEyo1 c55e5b9
Merge branch '2384-markbind-template-project' of https://github.com/K…
KevinEyo1 5ada339
Update contributor list
KevinEyo1 610e546
Fix indentations
KevinEyo1 ab51281
Add expected template files for testing
KevinEyo1 9721e3e
Remove contributor part
KevinEyo1 47ea93d
Remove traces of ab3
KevinEyo1 45b8846
Merge branch 'MarkBind:master' into master
KevinEyo1 a3e5ae2
Merge branch 'MarkBind:master' into 2384-markbind-template-project
KevinEyo1 fa5c24d
Update tests
KevinEyo1 21628f7
Merge branch 'MarkBind:master' into master
KevinEyo1 3c704a8
Merge branch 'MarkBind:master' into 2384-markbind-template-project
KevinEyo1 b0b9deb
Improve template based on reviews
KevinEyo1 6c9c3ad
Merge branch '2384-markbind-template-project' of https://github.com/K…
KevinEyo1 e39a176
Update expected tests
KevinEyo1 b606951
Merge branch 'master' into 2384-markbind-template-project
KevinEyo1 0f10968
Update project template
KevinEyo1 db30870
Change CustomListIconProcessor
KevinEyo1 9df6545
Add one-off feature
KevinEyo1 145abbd
Merge branch 'master' of https://github.com/KevinEyo1/markbind into 2…
KevinEyo1 75073c6
Update files
KevinEyo1 4c0c56c
Remove extra files
KevinEyo1 102ed81
Remove extra folder
KevinEyo1 969865f
Add how to check if permissions are given
yucheng11122017 46397e7
Merge branch 'master' of https://github.com/MarkBind/markbind
yucheng11122017 21fa90c
Merge branch 'master' of https://github.com/KevinEyo1/markbind
KevinEyo1 0bc66f7
Merge branch 'master' of https://github.com/MarkBind/markbind
yucheng11122017 0ebb7cd
Merge branch 'MarkBind:master' into master
KevinEyo1 74f8303
Add changes
KevinEyo1 f798b1d
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 ab7558a
Add tests
KevinEyo1 a22b67e
Improve code quality
KevinEyo1 48399bd
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 991e0cf
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 a5c316c
Fix comma
KevinEyo1 cb84513
Fix merge conflict
yucheng11122017 b13906f
Fix code
KevinEyo1 701183b
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 819326f
Merge conflicts
KevinEyo1 4a83981
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 7e7cfb7
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 5b40f9e
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 a86e121
Fix nits
KevinEyo1 9106fee
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 85cddf2
Merge branch '2405-customize-list-icon' of https://github.com/KevinEy…
KevinEyo1 5655e7a
Fix nit
KevinEyo1 32bbfd9
Update docs
KevinEyo1 bf8aac5
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 57a9f9a
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 4730eba
add stuff
5c8bcfe
kevin
9198725
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 64819db
Merge pull request #32 from leongdl135/master
KevinEyo1 e2f6301
Allocate space for scrollbar in nav components
jingting1412 eb69423
Fix merge conflict
yucheng11122017 936dadc
Fix merge conflict
yucheng11122017 5b9e7d7
Revert "Fix merge conflict"
yucheng11122017 77a6a80
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 61d729f
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 e5e4502
Update docs/userGuide/syntax/lists.md
KevinEyo1 db2d1a6
Update packages/cli/test/functional/test_site/testList.md
KevinEyo1 3ece3a7
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 89c9f79
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 786faec
Fix nits
KevinEyo1 2873a6e
Merge branch 'master' of https://github.com/MarkBind/markbind
KevinEyo1 5f2d3a9
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 a7a1f83
Update files
KevinEyo1 012ac3a
Merge branch 'MarkBind:master' into master
KevinEyo1 b146085
Merge branch 'MarkBind:master' into 2405-customize-list-icon
KevinEyo1 b06f509
Pull changes
KevinEyo1 1a93c87
Merge branch '2405-customize-list-icon' of https://github.com/KevinEy…
KevinEyo1 0d615fa
Fix files
KevinEyo1 1accdb9
Merge branch 'master' into 2405-customize-list-icon
KevinEyo1 38b4887
fix small nits
yucheng11122017 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using
one-off
because after the merging of #2444, this attribute will apply to not only the icon attributes :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i-once
(to make it shorter)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would combining the 2 and calling it
once
fine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think once is ok! @damithc I think not having the
i-
is better because this should apply to thet-
attributes as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the naming here?