-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug cannot import footnote from hash #2441
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
22b9289
Debug cannot import footnote from hash
yiwen101 8b3cc6d
Update includePanelProcessor.test.ts
yiwen101 c7d4915
Update includePanelProcessor.test.ts
yiwen101 168dd4c
Fix include footnote bug in user doc
yiwen101 f285220
Fix wrong spelling
yiwen101 eecebc2
Improve readability of test
yiwen101 a68e82a
Merge branch 'master' into include_footnote
yiwen101 52c316d
Merge branch 'master' into include_footnote
yiwen101 1f9dce4
Fix bug
yiwen101 6a441b3
Update test
yiwen101 a65218a
Improve readability of the test
yiwen101 e77a7bc
Improve getFootnodeNumber
yiwen101 bd50434
Merge branch 'master' into include_footnote
yiwen101 1e8a14e
Update packages/core/src/html/includePanelProcessor.ts
yiwen101 3146481
Improve code quality
yiwen101 003eeb7
Update includePanelProcessor.ts
yiwen101 53e3147
Update test
yiwen101 1b9f432
Remove omitted debugging log
yiwen101 db02850
Merge branch 'master' into include_footnote
yiwen101 9620126
Merge branch 'master' into include_footnote
yiwen101 54cc49f
Add comment
yiwen101 72168e0
Update packages/core/src/html/includePanelProcessor.ts
yiwen101 d555215
Merge branch 'master' into include_footnote
yiwen101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,5 +46,6 @@ belong to the previous footnote. | |
``` | ||
</div> | ||
<div id="examples" class="d-none"> | ||
|
||
1 + 1 = 2 ^[Math] | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 10 additions & 1 deletion
11
packages/cli/test/functional/test_site/expected/index.page-vue-render.js
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<div id="import"> | ||
|
||
text^[footnote1], text2^[footnote2] | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment to explain why we need to do a substring here? It is just to get rid of the hash in front right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment; has added the the latest commit