Simplify fix for abrupt panel transition

[luminousleek]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• Feature addition or enhancement
• Code maintenance
• DevOps
• Improve developer experience
• Others, please explain:

Fixes #2298

Overview of changes:

• Wrap the collapse button at the bottom of a panel in a <div> block and add bottom padding it.
• Revert the changes in Fix panel transition abruptly snapping to the end #2200.

Anything you'd like to highlight/discuss:
padding-bottom and margin-bottom are needed to prevent margin collapse

Testing instructions:

NA

Proposed commit message: (wrap lines at 72 characters)

Simplify fix for abrupt panel transition. 

The previous fix implemented a method to compute the max
height of a panel by checking if the collapse button is present
and adding the height of the bottom margin of the button.

Let's simplify this by wrapping the button in a <div> block and 
adding padding to the block. Let's also remove the getMaxHeight
method and its associated tests.

---

Checklist: ☑️

• Updated the documentation for feature additions and enhancements
• Added tests for bug fixes or features
• Linked all related issues
• No unrelated changes

---

Reviewer checklist:

Indicate the SEMVER impact of the PR:

• Major (when you make incompatible API changes)
• Minor (when you add functionality in a backward compatible manner)
• Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

• To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

• what was the old feature that was made obsolete
• any replacement feature (if any), and
• how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

[yucheng11122017]

Hi @luminousleek thanks so much for the work! The solution seems simple and effective. Kind of kicking myself for not doing this in the first place.
One minor nit on the class name and we should be good to do!

[yucheng11122017]

Maybe bottom-button-wrapper is a better class name? Its similar to what we call our button-wrapper class now :)

[yucheng11122017]

LGTM! Thanks for the work @luminousleek :))

missing update test

[yucheng11122017]

Hi @luminousleek could you run npm updatetest to update the expected test cases :)

[luminousleek]

this line was deleted when i ran npm run updatetest

[yucheng11122017]

Could you pull from the main branch? I think the change from the latest PR is not reflected thats why

[luminousleek]

hmm looks like the deleted line was from the previous PR. the lines added in the algolia.ts file in here are there too. anyhow i've manually added this line back.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ca4704) 48.87% compared to head (4c51140) 48.87%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2421   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files         124      124           
  Lines        5238     5238           
  Branches     1109     1109           
=======================================
  Hits         2560     2560           
  Misses       2371     2371           
  Partials      307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yucheng11122017]

LGTM! Thanks a bunch @luminousleek :)

[yucheng11122017]

@all-contributors please add @luminousleek for code

[allcontributors]

@yucheng11122017

I've put up a pull request to add @luminousleek! 🎉