-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkBind Template for Software Project Documentation #2400
MarkBind Template for Software Project Documentation #2400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
=======================================
Coverage 51.11% 51.11%
=======================================
Files 124 124
Lines 5355 5355
Branches 1152 1152
=======================================
Hits 2737 2737
Misses 2328 2328
Partials 290 290 ☔ View full report in Codecov by Sentry. |
As discussed with @damithc, will go with the approach of keeping the site minimal, using placeholder picture with captions and dummy texts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall looks good. I think that you should add this template to the tests too (for regression testing). Breaking changes can occur and we need to ensure that our template is updated.
For now, lets fix the bugs. Also, let me double check on the content template. |
…evinEyo1/markbind into 2384-markbind-template-project
For the testing files of the new template, I generated using the updatetest script, but it creates the files with a timestamp, such that when it does the comparison with newly created files, the timestamp generated is different. Do you know how to solve this @EltonGohJH ? |
As discussed, you can remove the footer with the timestamp. Also, remember to update your netlify template. I realised that your commit message can be improved. (Feel free to use chatgpt) |
@kaixin-hc @yucheng11122017 @itsyme @lhw-1 https://markbind-template-project.netlify.app/ I am thinking whether this template is minimal enough to be used in a general case? What do you all think about it? |
Hmmm imo, the user guide and home seems ok and minimal enough. I have some doubts about the developer guide though - in particular the design subsection which seems a bit too specific. I like the parts that show off markbind's functionality like puml diagrams and so on but the rest can be deleted i think. The two appendixes can be removed as well I believe.
tbh I think its ok for them to use this template since there is already an existing one made by yongliang which they can clone and work on more easily. |
I agree with @yucheng11122017 about the dev guide section, perhaps we could phrase it as "You can add pUml diagrams such as below! ..." to showcase MarkBind's features rather than the current verbosity of the example. I think the rest of the template is fine besides some minor nits like standardising some headers (e.g. X Feature -> Feature X)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nits tho! Particularly check the panels - I think its weird that you switched to HTML inside, any reason for that?
|
||
<box type="info" seamless> | ||
|
||
**Note:** The lifeline in the sequence diagram should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note doesn't refer to anything - delete or change it
**Note:** The lifeline in the sequence diagram should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram. | |
**Note:** You can use boxes to include details that you want to draw the reader's attention to. See [`boxes` feature](https://markbind.org/userGuide/components/presentation.html#boxes) |
This project has two types of tests: | ||
|
||
<panel header="**1. Unit tests**"> | ||
<p>These tests are targeting the lowest level methods/classes.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>These tests are targeting the lowest level methods/classes.</p> | |
These tests target the lowest level methods/classes. | |
Example command (replace with your own) `npm run test` |
I think you shouldn't have to use html here? Can you check. I feel that using <p>
tags is not really best / common markbind practie, though it's supported
@@ -0,0 +1,45 @@ | |||
--- | |||
layout: default.md | |||
title: "John Doe's Project Portfolio Page" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: "John Doe's Project Portfolio Page" | |
title: "Portfolio Page" |
…evinEyo1/markbind into 2384-markbind-template-project
…evinEyo1/markbind into 2384-markbind-template-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issues asked to be fixed are fixed
What is the purpose of this pull request?
Overview of changes:
#2384
Adapted files from ab3 repo for project documentation template.
Added deployed netlify site for project template to templates.md file in UG docs.
Anything you'd like to highlight/discuss:
Currently deployed site on templates.md is hosted on personal github repo and account.
Parts of ab3 still present in new template such as diagrams and parts of Dev Guide as I am not sure whether to completely remove them or not, since after removing them I find it hard to fully show examples of how those sections should look like. The expectation could be for it to be that minimal.
I am also unsure of the approach by which to do the pages in the sense of the following example:
For a section listing benefits of product, to write benefits of an example product like meeting scheduler, or be more meta in a sense and literally have a list like "List of benefits: Benefit 1, Benefit 2, Benefit3".
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
MarkBind templates: add a project-specific template
MarkBind has default and minimal templates.
MarkBind lacks a specific template for project documentation,
limiting its appeal to users seeking specialized starting points.
Creating a new template for such users enhances MarkBind's
usability by providing a tailored starting point for creating
project documentation, encouraging more users to choose
MarkBind for their documentation needs.
Let's add a
project
template option during MarkBindinitialization that generates a template specifically to project
documentation needs, with a User Guide and Developer Guide.
This approach directly addresses the gap for specialized
documentation templates, making MarkBind a more attractive
option for project maintainers.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):