Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkBind Template for Student Portfolio #2398

Merged
merged 62 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
a707f53
Add default files for template
jingting1412 Jan 29, 2024
e28ccbb
Basic structure
jingting1412 Feb 2, 2024
aa05707
Add content for template
jingting1412 Feb 2, 2024
7f295f1
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 2, 2024
665f5dc
Fix typo
jingting1412 Feb 2, 2024
84f1f46
Update userguide
jingting1412 Feb 3, 2024
8a7442a
Add link to netlify
jingting1412 Feb 3, 2024
2e49d48
implement changes
jingting1412 Feb 11, 2024
4272144
Change variable
jingting1412 Feb 11, 2024
b276680
Merge branch 'master' into portfolioTemplate
jingting1412 Feb 11, 2024
e181ca3
Merge branch 'master' into portfolioTemplate
jingting1412 Feb 14, 2024
3023603
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 16, 2024
b35ccbe
Shift skills section
jingting1412 Feb 16, 2024
be14ede
Fix variable mistake
jingting1412 Feb 16, 2024
f342c87
Add functional test
jingting1412 Feb 19, 2024
d4b2683
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 19, 2024
141436a
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 8, 2024
e3c3ba1
Remove previous tests
jingting1412 Mar 8, 2024
51707b6
Update tests
jingting1412 Mar 8, 2024
15becb6
Setup basic structure
jingting1412 Mar 8, 2024
26c87f5
Add content
jingting1412 Mar 9, 2024
76c8cd4
Add content for project
jingting1412 Mar 9, 2024
a2db2cb
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 10, 2024
5102863
Fix typo
jingting1412 Mar 10, 2024
31daffe
Implement review changes
jingting1412 Mar 10, 2024
168c494
Remove frontmatter
jingting1412 Mar 10, 2024
0302105
Content changes
jingting1412 Mar 11, 2024
6291d53
Improve layout
jingting1412 Mar 11, 2024
b7c7c6f
Fix typo
jingting1412 Mar 11, 2024
83a792f
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 12, 2024
32e28f5
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 15, 2024
0b8154d
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 20, 2024
9379471
Change content
jingting1412 Mar 20, 2024
2dc9d74
Add content
jingting1412 Mar 20, 2024
23bd94c
Add functional test
jingting1412 Mar 20, 2024
b3cd4b2
Add functional test
jingting1412 Mar 20, 2024
d473352
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 20, 2024
e5479b0
Update content and test
jingting1412 Mar 21, 2024
4da0e66
Update iframe width
jingting1412 Mar 21, 2024
e29cc29
Update test
jingting1412 Mar 21, 2024
3df3d95
Update packages/core/template/portfolio/index.md
jingting1412 Mar 30, 2024
71884e9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 30, 2024
d13495a
Merge branch 'master' into portfolioTemplate
jingting1412 Mar 30, 2024
f9f8262
Implement review suggestions
jingting1412 Mar 30, 2024
7f013b6
Update tests
jingting1412 Mar 30, 2024
e3c41f8
Add email link
jingting1412 Mar 30, 2024
1dce15e
Update tests
jingting1412 Mar 30, 2024
7800aee
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Apr 2, 2024
83e88e5
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
d2d5230
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
299f4a4
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
49245a5
Add links to projects
jingting1412 Apr 3, 2024
37dec16
Change name for post
jingting1412 Apr 3, 2024
612cbd9
Change look of experience
jingting1412 Apr 3, 2024
62a8fad
Update tests
jingting1412 Apr 3, 2024
4bf2a7a
Implement review changes
jingting1412 Apr 4, 2024
c83b6dd
Update tests
jingting1412 Apr 4, 2024
6cfe7b9
Update post
jingting1412 Apr 4, 2024
2aeb573
Remove unused image
jingting1412 Apr 4, 2024
b7dba93
Fix broken link
jingting1412 Apr 4, 2024
e3438a9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Apr 4, 2024
f3ded34
Fix merge conflicts
jingting1412 Apr 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/userGuide/templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Name | Template key | Description | Quick Deploy
---- | ------- | ----------- | ------------
Default | `default` | Default template if `--template` is unspecified. Includes core features such as site and page navigation for a more convenient quick start. | <a href="https://app.netlify.com/start/deploy?repository=https://github.com/MarkBind/init-typical-netlify"><img src="https://www.netlify.com/img/deploy/button.svg" /></a>
Minimal | `minimal` | Minimalistic template that gets you started quickly. | <a href="https://app.netlify.com/start/deploy?repository=https://github.com/MarkBind/init-minimal-netlify"><img src="https://www.netlify.com/img/deploy/button.svg" /></a>
Portfolio | `portfolio` | Portfolio template to quickly build your portfolio. | <a href=""><img src="https://www.netlify.com/img/deploy/button.svg" /></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Markbind team! I've been following this issue for quite a while but never got to see a preview of the Portfolio template. Maybe that is something you can consider adding to the documentation, perhaps a screenshot?

Copy link
Contributor

@kaixin-hc kaixin-hc Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - it shouldn't be too hard to add a modal with image examples 👀 heres a short video i took when i was reviewing if you'd like to add your comments as well (already somewhat outdated ya)

Screen.Recording.2024-03-10.at.2.58.47.PM.mov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I took a short look during the lecture today too, and it looks clean!

Not sure if this is possible on Markbind, but I think some of these expandable cards could be open by default? For example, the skills section, and maybe a few selected projects to emphasize the best ones.

I think the intro section ("My name is...") could be redesigned slightly if it is within the scope of this PR. For example, center the text, add a one-line intro, add call-to-action button(s) - for example, 'View Resume', or 'About Me', or the icon buttons for GitHub and LinkedIn can be added here

Just a few design suggestions, feel free to ignore

Copy link
Contributor Author

@jingting1412 jingting1412 Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Charisma! Thank you for your feedback. I think I can definitely change the skills section so the panels are open by default. For the projects section, each project is shown on an individual card so they are already open by default. I looked at your website again and I think the "featured projects" and "other projects" sections are interesting. Maybe the current big cards can be for featured projects, and I can add a grid of smaller cards underneath that to show other projects.

I think the "Hello!" section looks better with the text aligned to the left? It looks neater in my opinion. 😓
But I think I can def move the links to this header section

Also sorry about not having a netlify link previously, I've since set it up here: https://portfolio-template-markbind.netlify.app/

jingting1412 marked this conversation as resolved.
Show resolved Hide resolved


{% from "njk/common.njk" import previous_next %}
{{ previous_next('addingNavigationButtons', '') }}
1 change: 1 addition & 0 deletions packages/cli/test/functional/testSites.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const testConvertSites = [
const testTemplateSites = [
'minimal,test_site_templates/test_minimal',
'default,test_site_templates/test_default',
'portfolio,test_site_templates/test_portfolio',
];

// These files will be generated within test_site/expected/
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading