-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkBind Template for Student Portfolio #2398
Merged
yucheng11122017
merged 62 commits into
MarkBind:master
from
jingting1412:portfolioTemplate
Apr 8, 2024
Merged
Changes from 40 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
a707f53
Add default files for template
jingting1412 e28ccbb
Basic structure
jingting1412 aa05707
Add content for template
jingting1412 7f295f1
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 665f5dc
Fix typo
jingting1412 84f1f46
Update userguide
jingting1412 8a7442a
Add link to netlify
jingting1412 2e49d48
implement changes
jingting1412 4272144
Change variable
jingting1412 b276680
Merge branch 'master' into portfolioTemplate
jingting1412 e181ca3
Merge branch 'master' into portfolioTemplate
jingting1412 3023603
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 b35ccbe
Shift skills section
jingting1412 be14ede
Fix variable mistake
jingting1412 f342c87
Add functional test
jingting1412 d4b2683
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 141436a
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 e3c3ba1
Remove previous tests
jingting1412 51707b6
Update tests
jingting1412 15becb6
Setup basic structure
jingting1412 26c87f5
Add content
jingting1412 76c8cd4
Add content for project
jingting1412 a2db2cb
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 5102863
Fix typo
jingting1412 31daffe
Implement review changes
jingting1412 168c494
Remove frontmatter
jingting1412 0302105
Content changes
jingting1412 6291d53
Improve layout
jingting1412 b7c7c6f
Fix typo
jingting1412 83a792f
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 32e28f5
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 0b8154d
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 9379471
Change content
jingting1412 2dc9d74
Add content
jingting1412 23bd94c
Add functional test
jingting1412 b3cd4b2
Add functional test
jingting1412 d473352
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 e5479b0
Update content and test
jingting1412 4da0e66
Update iframe width
jingting1412 e29cc29
Update test
jingting1412 3df3d95
Update packages/core/template/portfolio/index.md
jingting1412 71884e9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 d13495a
Merge branch 'master' into portfolioTemplate
jingting1412 f9f8262
Implement review suggestions
jingting1412 7f013b6
Update tests
jingting1412 e3c41f8
Add email link
jingting1412 1dce15e
Update tests
jingting1412 7800aee
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 83e88e5
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 d2d5230
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 299f4a4
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 49245a5
Add links to projects
jingting1412 37dec16
Change name for post
jingting1412 612cbd9
Change look of experience
jingting1412 62a8fad
Update tests
jingting1412 4bf2a7a
Implement review changes
jingting1412 c83b6dd
Update tests
jingting1412 6cfe7b9
Update post
jingting1412 2aeb573
Remove unused image
jingting1412 b7dba93
Fix broken link
jingting1412 e3438a9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 f3ded34
Fix merge conflicts
jingting1412 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...onal/test_site_templates/test_portfolio/expected/contents/assets/JavaScript.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+402 KB
...test_site_templates/test_portfolio/expected/contents/assets/MarkbindExample.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions
1
...e_templates/test_portfolio/expected/contents/assets/Placeholder_view_vector.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions
4
...onal/test_site_templates/test_portfolio/expected/contents/assets/Typescript.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions
2
.../functional/test_site_templates/test_portfolio/expected/contents/assets/Vue.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.67 KB
..._site_templates/test_portfolio/expected/contents/assets/default_profile_pic.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions
1
...ional/test_site_templates/test_portfolio/expected/contents/assets/java-icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Markbind team! I've been following this issue for quite a while but never got to see a preview of the Portfolio template. Maybe that is something you can consider adding to the documentation, perhaps a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - it shouldn't be too hard to add a modal with image examples 👀 heres a short video i took when i was reviewing if you'd like to add your comments as well (already somewhat outdated ya)
Screen.Recording.2024-03-10.at.2.58.47.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I took a short look during the lecture today too, and it looks clean!
Not sure if this is possible on Markbind, but I think some of these expandable cards could be open by default? For example, the skills section, and maybe a few selected projects to emphasize the best ones.
I think the intro section ("My name is...") could be redesigned slightly if it is within the scope of this PR. For example, center the text, add a one-line intro, add call-to-action button(s) - for example, 'View Resume', or 'About Me', or the icon buttons for GitHub and LinkedIn can be added here
Just a few design suggestions, feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Charisma! Thank you for your feedback. I think I can definitely change the skills section so the panels are open by default. For the projects section, each project is shown on an individual card so they are already open by default. I looked at your website again and I think the "featured projects" and "other projects" sections are interesting. Maybe the current big cards can be for featured projects, and I can add a grid of smaller cards underneath that to show other projects.
I think the "Hello!" section looks better with the text aligned to the left? It looks neater in my opinion. 😓
But I think I can def move the links to this header section
Also sorry about not having a netlify link previously, I've since set it up here: https://portfolio-template-markbind.netlify.app/