-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkBind Template for Student Portfolio #2398
Changes from 11 commits
a707f53
e28ccbb
aa05707
7f295f1
665f5dc
84f1f46
8a7442a
2e49d48
4272144
b276680
e181ca3
3023603
b35ccbe
be14ede
f342c87
d4b2683
141436a
e3c3ba1
51707b6
15becb6
26c87f5
76c8cd4
a2db2cb
5102863
31daffe
168c494
0302105
6291d53
b7c7c6f
83a792f
32e28f5
0b8154d
9379471
2dc9d74
23bd94c
b3cd4b2
d473352
e5479b0
4da0e66
e29cc29
3df3d95
71884e9
d13495a
f9f8262
7f013b6
e3c41f8
1dce15e
7800aee
83e88e5
d2d5230
299f4a4
49245a5
37dec16
612cbd9
62a8fad
4bf2a7a
c83b6dd
6cfe7b9
2aeb573
b7dba93
e3438a9
f3ded34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
lerna-debug.log* | ||
_markbind/logs/ | ||
|
||
# Dependency directories | ||
node_modules/ | ||
|
||
# Production | ||
_site/ | ||
|
||
# Env | ||
.env | ||
.env.local | ||
|
||
# IDE configs | ||
.vscode/ | ||
.idea/* | ||
*.iml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<frontmatter> | ||
title: Page not found | ||
layout: 404.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this accessible at any point? HAHA |
||
</frontmatter> | ||
|
||
-><p style="font-size: 10rem">404</p><- | ||
-><p style="font-size: 1.5rem">File not found<br>Click <a href="/">here</a> to go back to the home page.</p><- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<div>{{ content }}</div> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
<head-bottom> | ||
<link rel="stylesheet" href="{{baseUrl}}/stylesheets/main.css"> | ||
</head-bottom> | ||
|
||
<header sticky> | ||
<navbar type="dark"> | ||
<a slot="brand" href="{{baseUrl}}/index.html" title="Home" class="navbar-brand">Your Name</a> | ||
<li><a href="{{baseUrl}}/contents/experience.html" class="nav-link">Experience</a></li> | ||
<li><a href="{{baseUrl}}/contents/skills.html" class="nav-link">Skills</a></li> | ||
<dropdown header="Projects" class="nav-link"> | ||
<li><a href="{{baseUrl}}/contents/project1.html" class="dropdown-item">Project1</a></li> | ||
<li><a href="{{baseUrl}}/contents/project2.html" class="dropdown-item">Project2</a></li> | ||
</dropdown> | ||
<li><a href="https://github.com/MarkBind/markbind" target="_blank" class="nav-link"> | ||
<i class="fa-brands fa-github fa-lg"></i> | ||
</a> | ||
</li> | ||
<li> | ||
<a href="https://www.linkedin.com/school/national-university-of-singapore/" target="_blank" class="nav-link"> | ||
<i class="fa-brands fa-linkedin fa-lg"></i> | ||
</a> | ||
</li> | ||
<li slot="right"> | ||
<form class="navbar-form"> | ||
<searchbar :data="searchData" placeholder="Search" :on-hit="searchCallback" menu-align-right></searchbar> | ||
</form> | ||
</li> | ||
</navbar> | ||
</header> | ||
|
||
<div id="flex-body"> | ||
<nav id="site-nav"> | ||
<div class="site-nav-top"> | ||
<div class="fw-bold mb-2" style="font-size: 1.25rem;">Contents</div> | ||
</div> | ||
<div class="nav-component slim-scroll"> | ||
<site-nav> | ||
* [Home :house:]({{ baseUrl }}/index.html) | ||
* [Experience]({{baseUrl}}/contents/experience.html) | ||
* [Skills]({{baseUrl}}/contents/skills.html) | ||
* Projects :expanded: | ||
* [Project 1]({{baseUrl}}/contents/project1.html) | ||
* [Project 2]({{baseUrl}}/contents/project2.html) | ||
</site-nav> | ||
</div> | ||
</nav> | ||
<div id="content-wrapper"> | ||
<breadcrumb /> | ||
{{ content }} | ||
</div> | ||
<nav id="page-nav"> | ||
<div class="nav-component slim-scroll"> | ||
<page-nav /> | ||
</div> | ||
</nav> | ||
<scroll-top-button></scroll-top-button> | ||
</div> | ||
|
||
<footer> | ||
<!-- Support MarkBind by including a link to us on your landing page! --> | ||
<div class="text-center"> | ||
<small>[Generated by {{MarkBind}}]</small> | ||
</div> | ||
</footer> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"jsonVariableExample": "Your variables can be defined here as well" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not used? Maybe remove? |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<variable name="name"> | ||
YOUR NAME | ||
</variable> | ||
jingting1412 marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<frontmatter> | ||
title: Experience | ||
</frontmatter> | ||
|
||
<br> | ||
|
||
# Experience | ||
|
||
> This is a placeholder page for your work experiences | ||
yucheng11122017 marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<frontmatter> | ||
title: Project 1 | ||
</frontmatter> | ||
|
||
<br> | ||
|
||
# Project 1 | ||
|
||
> This is a placeholder page for a project. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<frontmatter> | ||
title: Project 2 | ||
</frontmatter> | ||
|
||
<br> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deleting this linebreak and the one in project 2 does not seem to have any effect, wld suggest removing them |
||
|
||
# Project 2 | ||
|
||
> This is a placeholder page for a project. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<frontmatter> | ||
title: Skills | ||
</frontmatter> | ||
|
||
<br> | ||
|
||
# Skills | ||
|
||
> This is a placeholder page for your skills. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<frontmatter> | ||
title: Home Page | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep in mind the use of frontmatter :https://markbind.org/userGuide/tweakingThePageStructure.html#frontmatter and omitFrontmatter (btw - if you're looking for more issues to pick up, you can consider adding to the discussion here: #2295 ) Anyway, because of the use of includes in this page, the page title is not Home Page but that of the last included file. Could you go through and remove irrelevant frontmatter? Might be worthwhile to also include in a code comment the purpose of frontmatter on this page |
||
layout: default.md | ||
pageNav: 4 | ||
pageNavTitle: "Topics" | ||
</frontmatter> | ||
|
||
<br> | ||
|
||
<div class="bg-dark text-white px-2 py-5 mb-4"> | ||
<div class="container"> | ||
<h1 class="display-5 no-index">Hello!<br>You've just initialised a personal portfolio template in MarkBind</h1> | ||
<p class="lead">Here's what you can add...</p> | ||
</div> | ||
</div> | ||
|
||
--- | ||
|
||
## Hello there! I'm {{name}} | ||
|
||
This is where you can add a picture of yourself and a brief introduction | ||
|
||
<div class='container'> | ||
<img src='./contents/assests/default_profile_pic.png' alt='default-profile-pic'></img> | ||
<p style="padding-left:10px">You can use this area to give a brief introduction about yourself. You can include your github ( | ||
<a href="https://github.com/MarkBind/markbind"> | ||
<i class="fa-brands fa-github fa-lg"></i> | ||
</a> | ||
), linkedIn ( | ||
<a href="https://www.linkedin.com/school/national-university-of-singapore/"> | ||
<i class="fa-brands fa-linkedin fa-lg"></i> | ||
</a> | ||
), and other important links. You can also give a quick overview of the technologies and frameworks you know using our <a href="https://markbind.org/userGuide/components/imagesAndDiagrams.html#thumbnails" target="_blank">thumbnail feature</a> or our <a href="https://markbind.org/userGuide/formattingContents.html#icons" target="_blank">icons</a>. | ||
</p> | ||
<panel header="Example using thumbnails" minimized> | ||
<thumbnail src='./contents/assests/JavaScript.svg' size="100"/> | ||
<thumbnail src='./contents/assests/Typescript.svg' size="100"/> | ||
<thumbnail src='./contents/assests/Vue.svg' size="100"/> | ||
</panel> | ||
<br/> | ||
<panel header="Example using icons" minimized> | ||
Some icons are not available in the libraries MarkBind supports! Please ensure that | ||
the desired icons are available beofre choosing this option. | ||
<br/> | ||
<i class="fa-brands fa-square-js fa-2xl"></i> | ||
<i class="fa-brands fa-vuejs fa-2xl"></i> | ||
</panel> | ||
|
||
</div> | ||
|
||
--- | ||
|
||
## Navigating this site | ||
|
||
This site comes pre-configured with the core <a href="https://markbind.org/userGuide/components/navigation.html#navigation-components" target="_blank">Navigation components</a>: a <tooltip content="Site Navigation">**siteNav**</tooltip>, a <tooltip content="Page Navigation">**pageNav**</tooltip>, a <tooltip content="Navigation Bar">**NavBar**</tooltip>, and a **Search Bar**. To help you get started with the **siteNav**, we have included <tooltip content="experience, skills, projects, project1, project2">five dummy placeholder pages</tooltip>. The **NavBar** also comes with a placeholder slot for your name. | ||
|
||
--- | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,28 @@ | ||||||
{ | ||||||
"baseUrl": "", | ||||||
"titlePrefix": "", | ||||||
"titleSuffix": "", | ||||||
"ignore": [ | ||||||
"_markbind/layouts/*", | ||||||
"_markbind/logs/*", | ||||||
"_site/*", | ||||||
"site.json", | ||||||
"*.md", | ||||||
"*.njk", | ||||||
".git/*", | ||||||
".gitignore", | ||||||
"node_modules/*" | ||||||
], | ||||||
"pagesExclude": ["node_modules/*"], | ||||||
"pages": [ | ||||||
{ | ||||||
"src": "index.md" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add
Otherwise the title of the page is currently Project 2 |
||||||
}, | ||||||
{ | ||||||
"glob": ["**/index.md", "**/*.md"] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Don't need to include content/project1.md all these! |
||||||
} | ||||||
], | ||||||
"deploy": { | ||||||
"message": "Site Update." | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Markbind team! I've been following this issue for quite a while but never got to see a preview of the Portfolio template. Maybe that is something you can consider adding to the documentation, perhaps a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - it shouldn't be too hard to add a modal with image examples 👀 heres a short video i took when i was reviewing if you'd like to add your comments as well (already somewhat outdated ya)
Screen.Recording.2024-03-10.at.2.58.47.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I took a short look during the lecture today too, and it looks clean!
Not sure if this is possible on Markbind, but I think some of these expandable cards could be open by default? For example, the skills section, and maybe a few selected projects to emphasize the best ones.
I think the intro section ("My name is...") could be redesigned slightly if it is within the scope of this PR. For example, center the text, add a one-line intro, add call-to-action button(s) - for example, 'View Resume', or 'About Me', or the icon buttons for GitHub and LinkedIn can be added here
Just a few design suggestions, feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Charisma! Thank you for your feedback. I think I can definitely change the skills section so the panels are open by default. For the projects section, each project is shown on an individual card so they are already open by default. I looked at your website again and I think the "featured projects" and "other projects" sections are interesting. Maybe the current big cards can be for featured projects, and I can add a grid of smaller cards underneath that to show other projects.
I think the "Hello!" section looks better with the text aligned to the left? It looks neater in my opinion. 😓
But I think I can def move the links to this header section
Also sorry about not having a netlify link previously, I've since set it up here: https://portfolio-template-markbind.netlify.app/