Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkBind Template for Student Portfolio #2398

Merged
merged 62 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
a707f53
Add default files for template
jingting1412 Jan 29, 2024
e28ccbb
Basic structure
jingting1412 Feb 2, 2024
aa05707
Add content for template
jingting1412 Feb 2, 2024
7f295f1
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 2, 2024
665f5dc
Fix typo
jingting1412 Feb 2, 2024
84f1f46
Update userguide
jingting1412 Feb 3, 2024
8a7442a
Add link to netlify
jingting1412 Feb 3, 2024
2e49d48
implement changes
jingting1412 Feb 11, 2024
4272144
Change variable
jingting1412 Feb 11, 2024
b276680
Merge branch 'master' into portfolioTemplate
jingting1412 Feb 11, 2024
e181ca3
Merge branch 'master' into portfolioTemplate
jingting1412 Feb 14, 2024
3023603
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 16, 2024
b35ccbe
Shift skills section
jingting1412 Feb 16, 2024
be14ede
Fix variable mistake
jingting1412 Feb 16, 2024
f342c87
Add functional test
jingting1412 Feb 19, 2024
d4b2683
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Feb 19, 2024
141436a
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 8, 2024
e3c3ba1
Remove previous tests
jingting1412 Mar 8, 2024
51707b6
Update tests
jingting1412 Mar 8, 2024
15becb6
Setup basic structure
jingting1412 Mar 8, 2024
26c87f5
Add content
jingting1412 Mar 9, 2024
76c8cd4
Add content for project
jingting1412 Mar 9, 2024
a2db2cb
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 10, 2024
5102863
Fix typo
jingting1412 Mar 10, 2024
31daffe
Implement review changes
jingting1412 Mar 10, 2024
168c494
Remove frontmatter
jingting1412 Mar 10, 2024
0302105
Content changes
jingting1412 Mar 11, 2024
6291d53
Improve layout
jingting1412 Mar 11, 2024
b7c7c6f
Fix typo
jingting1412 Mar 11, 2024
83a792f
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 12, 2024
32e28f5
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 15, 2024
0b8154d
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 20, 2024
9379471
Change content
jingting1412 Mar 20, 2024
2dc9d74
Add content
jingting1412 Mar 20, 2024
23bd94c
Add functional test
jingting1412 Mar 20, 2024
b3cd4b2
Add functional test
jingting1412 Mar 20, 2024
d473352
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 20, 2024
e5479b0
Update content and test
jingting1412 Mar 21, 2024
4da0e66
Update iframe width
jingting1412 Mar 21, 2024
e29cc29
Update test
jingting1412 Mar 21, 2024
3df3d95
Update packages/core/template/portfolio/index.md
jingting1412 Mar 30, 2024
71884e9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Mar 30, 2024
d13495a
Merge branch 'master' into portfolioTemplate
jingting1412 Mar 30, 2024
f9f8262
Implement review suggestions
jingting1412 Mar 30, 2024
7f013b6
Update tests
jingting1412 Mar 30, 2024
e3c41f8
Add email link
jingting1412 Mar 30, 2024
1dce15e
Update tests
jingting1412 Mar 30, 2024
7800aee
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Apr 2, 2024
83e88e5
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
d2d5230
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
299f4a4
Update packages/cli/test/functional/test_site_templates/test_portfoli…
jingting1412 Apr 3, 2024
49245a5
Add links to projects
jingting1412 Apr 3, 2024
37dec16
Change name for post
jingting1412 Apr 3, 2024
612cbd9
Change look of experience
jingting1412 Apr 3, 2024
62a8fad
Update tests
jingting1412 Apr 3, 2024
4bf2a7a
Implement review changes
jingting1412 Apr 4, 2024
c83b6dd
Update tests
jingting1412 Apr 4, 2024
6cfe7b9
Update post
jingting1412 Apr 4, 2024
2aeb573
Remove unused image
jingting1412 Apr 4, 2024
b7dba93
Fix broken link
jingting1412 Apr 4, 2024
e3438a9
Merge branch 'MarkBind:master' into portfolioTemplate
jingting1412 Apr 4, 2024
f3ded34
Fix merge conflicts
jingting1412 Apr 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/userGuide/templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Name | Template key | Description | Quick Deploy
---- | ------- | ----------- | ------------
Default | `default` | Default template if `--template` is unspecified. Includes core features such as site and page navigation for a more convenient quick start. | <a href="https://app.netlify.com/start/deploy?repository=https://github.com/MarkBind/init-typical-netlify"><img src="https://www.netlify.com/img/deploy/button.svg" /></a>
Minimal | `minimal` | Minimalistic template that gets you started quickly. | <a href="https://app.netlify.com/start/deploy?repository=https://github.com/MarkBind/init-minimal-netlify"><img src="https://www.netlify.com/img/deploy/button.svg" /></a>
Portfolio | `portfolio` | Portfolio template to quickly build your portfolio. | <a href="https://heartfelt-faun-d2a60d.netlify.app"><img src="https://www.netlify.com/img/deploy/button.svg" /></a>
jingting1412 marked this conversation as resolved.
Show resolved Hide resolved


{% from "njk/common.njk" import previous_next %}
{{ previous_next('addingNavigationButtons', '') }}
23 changes: 23 additions & 0 deletions packages/core/template/portfolio/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*
_markbind/logs/

# Dependency directories
node_modules/

# Production
_site/

# Env
.env
.env.local

# IDE configs
.vscode/
.idea/*
*.iml
7 changes: 7 additions & 0 deletions packages/core/template/portfolio/404.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<frontmatter>
title: Page not found
layout: 404.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accessible at any point? HAHA

</frontmatter>

-><p style="font-size: 10rem">404</p><-
-><p style="font-size: 1.5rem">File not found<br>Click <a href="/">here</a> to go back to the home page.</p><-
1 change: 1 addition & 0 deletions packages/core/template/portfolio/_markbind/layouts/404.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div>{{ content }}</div>
64 changes: 64 additions & 0 deletions packages/core/template/portfolio/_markbind/layouts/default.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<head-bottom>
<link rel="stylesheet" href="{{baseUrl}}/stylesheets/main.css">
</head-bottom>

<header sticky>
<navbar type="dark">
<a slot="brand" href="{{baseUrl}}/index.html" title="Home" class="navbar-brand">Your Name</a>
<li><a href="{{baseUrl}}/contents/experience.html" class="nav-link">Experience</a></li>
<li><a href="{{baseUrl}}/contents/skills.html" class="nav-link">Skills</a></li>
<dropdown header="Projects" class="nav-link">
<li><a href="{{baseUrl}}/contents/project1.html" class="dropdown-item">Project1</a></li>
<li><a href="{{baseUrl}}/contents/project2.html" class="dropdown-item">Project2</a></li>
</dropdown>
<li><a href="https://github.com/MarkBind/markbind" target="_blank" class="nav-link">
<i class="fa-brands fa-github fa-lg"></i>
</a>
</li>
<li>
<a href="https://www.linkedin.com/school/national-university-of-singapore/" target="_blank" class="nav-link">
<i class="fa-brands fa-linkedin fa-lg"></i>
</a>
</li>
<li slot="right">
<form class="navbar-form">
<searchbar :data="searchData" placeholder="Search" :on-hit="searchCallback" menu-align-right></searchbar>
</form>
</li>
</navbar>
</header>

<div id="flex-body">
<nav id="site-nav">
<div class="site-nav-top">
<div class="fw-bold mb-2" style="font-size: 1.25rem;">Contents</div>
</div>
<div class="nav-component slim-scroll">
<site-nav>
* [Home :house:]({{ baseUrl }}/index.html)
* [Experience]({{baseUrl}}/contents/experience.html)
* [Skills]({{baseUrl}}/contents/skills.html)
* Projects :expanded:
* [Project 1]({{baseUrl}}/contents/project1.html)
* [Project 2]({{baseUrl}}/contents/project2.html)
</site-nav>
</div>
</nav>
<div id="content-wrapper">
<breadcrumb />
{{ content }}
</div>
<nav id="page-nav">
<div class="nav-component slim-scroll">
<page-nav />
</div>
</nav>
<scroll-top-button></scroll-top-button>
</div>

<footer>
<!-- Support MarkBind by including a link to us on your landing page! -->
<div class="text-center">
<small>[Generated by {{MarkBind}}]</small>
</div>
</footer>
3 changes: 3 additions & 0 deletions packages/core/template/portfolio/_markbind/variables.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"jsonVariableExample": "Your variables can be defined here as well"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used? Maybe remove?

}
4 changes: 4 additions & 0 deletions packages/core/template/portfolio/_markbind/variables.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<variable name="example">
To inject this HTML segment in your MarkBind files, use {{ example }} where you want to place it.
More generally, surround the segment's id with double curly braces.
</variable>
jingting1412 marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions packages/core/template/portfolio/contents/assests/Vue.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions packages/core/template/portfolio/contents/experience.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<frontmatter>
title: Experience
</frontmatter>

<br>

# Experience

> This is a placeholder page for your work experiences
yucheng11122017 marked this conversation as resolved.
Show resolved Hide resolved
9 changes: 9 additions & 0 deletions packages/core/template/portfolio/contents/project1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<frontmatter>
title: Project 1
</frontmatter>

<br>

# Project 1

> This is a placeholder page for a project.
9 changes: 9 additions & 0 deletions packages/core/template/portfolio/contents/project2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<frontmatter>
title: Project 2
</frontmatter>

<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this linebreak and the one in project 2 does not seem to have any effect, wld suggest removing them


# Project 2

> This is a placeholder page for a project.
9 changes: 9 additions & 0 deletions packages/core/template/portfolio/contents/skills.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<frontmatter>
title: Skills
</frontmatter>

<br>

# Skills

> This is a placeholder page for your skills.
97 changes: 97 additions & 0 deletions packages/core/template/portfolio/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
<frontmatter>
title: Home Page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind the use of frontmatter :https://markbind.org/userGuide/tweakingThePageStructure.html#frontmatter and omitFrontmatter

(btw - if you're looking for more issues to pick up, you can consider adding to the discussion here: #2295 )

Anyway, because of the use of includes in this page, the page title is not Home Page but that of the last included file. Could you go through and remove irrelevant frontmatter? Might be worthwhile to also include in a code comment the purpose of frontmatter on this page

layout: default.md
pageNav: 4
pageNavTitle: "Topics"
</frontmatter>

<br>

<div class="bg-dark text-white px-2 py-5 mb-4">
<div class="container">
<h1 class="display-5 no-index">Hello!<br>You've just initialised a personal portfolio template in MarkBind</h1>
<p class="lead">Here's what you can add...</p>
</div>
</div>

---

## Hello there! I'm [YOUR NAME]
jingting1412 marked this conversation as resolved.
Show resolved Hide resolved

This is where you can add a picture of yourself and a brief introduction

<div class='container'>
<img src='./contents/assests/default_profile_pic.png' alt='default-profile-pic'></img>
<p style="padding-left:10px">You can use this area to give a brief introduction about yourself. You can include your github (
<a href="https://github.com/MarkBind/markbind">
<i class="fa-brands fa-github fa-lg"></i>
</a>
), linkedIn (
<a href="https://www.linkedin.com/school/national-university-of-singapore/">
<i class="fa-brands fa-linkedin fa-lg"></i>
</a>
), and other important links. You can also give a quick overview of the technologies and frameworks you know using our <a href="https://markbind.org/userGuide/components/imagesAndDiagrams.html#thumbnails" target="_blank">thumbnail feature</a> or our <a href="https://markbind.org/userGuide/formattingContents.html#icons" target="_blank">icons</a>.
</p>
<panel header="Example using thumbnails" minimized>
<thumbnail src='./contents/assests/JavaScript.svg' size="100"/>
<thumbnail src='./contents/assests/Typescript.svg' size="100"/>
<thumbnail src='./contents/assests/Vue.svg' size="100"/>
</panel>
<br/>
<panel header="Example using icons" minimized>
Some icons are not available in the libraries MarkBind supports! Please ensure that
the desired icons are available beofre choosing this option.
<br/>
<i class="fa-brands fa-square-js fa-2xl"></i>
<i class="fa-brands fa-vuejs fa-2xl"></i>
</panel>

</div>

---

## Navigating this site

This site comes pre-configured with the core <a href="https://markbind.org/userGuide/components/navigation.html#navigation-components" target="_blank">Navigation components</a>: a <tooltip content="Site Navigation">**siteNav**</tooltip>, a <tooltip content="Page Navigation">**pageNav**</tooltip>, a <tooltip content="Navigation Bar">**NavBar**</tooltip>, and a **Search Bar**. To help you get started with the **siteNav**, we have included <tooltip content="experience, skills, projects, project1, project2">five dummy placeholder pages</tooltip>. The **NavBar** also comes with a placeholder slot for your name.

---

## Guide to MarkBind

To see the capability of MarkBind in action, feel free to take a look at some of the websites built using MarkBind on our <a href="https://markbind.org/showcase.html" target="_blank">Showcase</a> page.

For more information on how to work with MarkBind sites and to add content, refer to our comprehensive <a href="https://markbind.org/userGuide/gettingStarted.html" target="_blank">User Guide</a>.

<box type="info">
jingting1412 marked this conversation as resolved.
Show resolved Hide resolved

If you are interested in contributing to MarkBind, you can refer to our <a href="https://markbind.org/devdocs/devGuide/devGuide.html" target="_blank">Developer Guide</a> as well!

</box>

<panel header="**Good starting points in our User Guide**" expanded no-close>

##### **User Guide: Authoring Contents**

> Learn about the variety of syntax schemes, formats, and custom MarkBind components that you can use in your MarkBind site.

More info in: _<a href="https://markbind.org/userGuide/authoringContents.html" target="_blank">User Guide → Authoring Contents</a>_

---

##### **User Guide: Working with Sites**

> Learn how to modify site properties, apply themes, and enable/disable plugins for your MarkBind site.

More info in: _<a href="https://markbind.org/userGuide/workingWithSites.html" target="_blank">User Guide → Working with Sites</a>_

---

##### **User Guide: Full Syntax Reference**

> Refer to our Full Syntax Reference page to find a specific feature or component that you want to use in your MarkBind site.

More info in: _<a href="https://markbind.org/userGuide/fullSyntaxReference.html" target="_blank">User Guide → Full Syntax Reference</a>_

</panel>

---
28 changes: 28 additions & 0 deletions packages/core/template/portfolio/site.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"baseUrl": "",
"titlePrefix": "",
"titleSuffix": "",
"ignore": [
"_markbind/layouts/*",
"_markbind/logs/*",
"_site/*",
"site.json",
"*.md",
"*.njk",
".git/*",
".gitignore",
"node_modules/*"
],
"pagesExclude": ["node_modules/*"],
"pages": [
{
"src": "index.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

"title": "Portfolio"

Otherwise the title of the page is currently Project 2

},
{
"glob": ["**/index.md", "**/*.md"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"glob": ["**/index.md", "**/*.md"]
"glob": ["**/index.md"]

Don't need to include content/project1.md all these!
Its also messing up the search

}
],
"deploy": {
"message": "Site Update."
}
}
Loading
Loading