Annotate support different labels #2388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Address #1911
Overview of changes:
Add slot to
a-point
which allows users to customise their own shape.Default shape remains a rounded button
Anything you'd like to highlight/discuss:
Options shape, color and opacity does not work when using this customised shape.
I was thinking it can left as it is now (ie shape, color and opacity option helps to control for default button while users can use inline css to style the customised shape)
Alternatively, I can try to see if it can be used to style the customised shape as well.
Testing instructions:
Include this in a file:
Proposed commit message: (wrap lines at 72 characters)
Add customised shape for annotate point
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):