Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in scroll to top feature #2374

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

tlylt
Copy link
Contributor

@tlylt tlylt commented Oct 23, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fix a typo on the scroll-to-top button usage, closes #2342

Anything you'd like to highlight/discuss:
nil

Testing instructions:
https://deploy-preview-2374--markbind-master.netlify.app/userguide/components/navigation#scroll-to-top-button

Proposed commit message: (wrap lines at 72 characters)
Fix typo in scroll to top feature


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@tlylt tlylt requested a review from damithc October 23, 2023 10:10
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2374 (5d43ac6) into master (5a73c80) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   45.66%   45.66%           
=======================================
  Files         123      123           
  Lines        5199     5199           
  Branches     1097     1097           
=======================================
  Hits         2374     2374           
  Misses       2506     2506           
  Partials      319      319           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tlylt tlylt added this to the v5.1.1 milestone Nov 18, 2023
@tlylt tlylt added the r.Patch Version resolver: increment by 0.0.1 label Nov 18, 2023
@tlylt tlylt merged commit 2a12b5c into MarkBind:master Nov 18, 2023
7 checks passed
@tlylt tlylt deleted the fix-button-html branch November 18, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r.Patch Version resolver: increment by 0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UG: typo in scroll to top feature
2 participants