Fix missing anchor icons when anchor in URL does not exist (#552)

MarkBind · Jan 6, 2019 · dfceca4 · dfceca4
1 parent ac3db42
commit dfceca4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/asset/js/setup.js b/asset/js/setup.js
@@ -5,8 +5,11 @@ Vue.use(VueStrap);
 function scrollToUrlAnchorHeading() {
   if (window.location.hash) {
     // remove leading hash to get element ID
-    document.getElementById(window.location.hash.slice(1)).scrollIntoView();
-    window.scrollBy(0, -document.body.style.paddingTop.replace('px', ''));
+    const headingElement = document.getElementById(window.location.hash.slice(1));
+    if (headingElement) {
+      headingElement.scrollIntoView();
+      window.scrollBy(0, -document.body.style.paddingTop.replace('px', ''));
+    }
   }
 }
 

diff --git a/test/test_site/expected/markbind/js/setup.js b/test/test_site/expected/markbind/js/setup.js
@@ -5,8 +5,11 @@ Vue.use(VueStrap);
 function scrollToUrlAnchorHeading() {
   if (window.location.hash) {
     // remove leading hash to get element ID
-    document.getElementById(window.location.hash.slice(1)).scrollIntoView();
-    window.scrollBy(0, -document.body.style.paddingTop.replace('px', ''));
+    const headingElement = document.getElementById(window.location.hash.slice(1));
+    if (headingElement) {
+      headingElement.scrollIntoView();
+      window.scrollBy(0, -document.body.style.paddingTop.replace('px', ''));
+    }
   }
 }