deb: DEBIAN_FRONTEND=noninteractive is ENV not ARG #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add worker for openeuler 24.03. Rename container generation to mathc the same name.
As per https://github.com/MariaDB/server/blob/8478a06cdbb7281e1cc2d507f18c985c736c2ffc/cmake/cpack_rpm.cmake#L374 MariaDB-compat won't be built for OpenEuler.
Clients in our binary taballs are linked dynamically with libncurses, which causes a trouble on systems where it is no longer available As per MDBF-794 only centos7 and debian 10 bintar builders need to link statically with libncurses. - for debian 10: libncurses.a is already present in /scripts/local/lib/ and -DCURSES_NEED_NCURSES=1 flag is enough to link it statically. - for centos7: I've rebuilt the image and pushed manually a dev_ tag. libncurses.a was present on the system but not in the library path: /scripts/local/lib/ Tests available at: - debian10: https://buildbot.dev.mariadb.org/#/builders/187/builds/23 - centos7: https://buildbot.dev.mariadb.org/#/builders/172/builds/292 Reference CMAKE output line: -- Found Curses: /scripts/local/lib/libncurses.a
Adjust images to 1505 notation as well.
Fedora 41 is including MariaDB 10.11 so use that as the minimum version.
It needs to be an ENV to be passed though to apt-get commands.
| @@ -8,7 +8,7 @@ FROM "$BASE_IMAGE" | |||
| LABEL maintainer="MariaDB Buildbot maintainers" | |||
|
|
|||
| # This will make apt-get install without question | |||
| ARG DEBIAN_FRONTEND=noninteractive | |||
| ENV DEBIAN_FRONTEND=noninteractive | |||
There was a problem hiding this comment.
Do we want this setting to persist in the built image?
We may need to get an interactive shell into the container and do some package operations where a human prompt would be useful. (and we forget about this setting).
Maybe switching it back to default at the end of the block where its needed?
Or use it specifically for the commands that can cause problems and -y is just not enough.
There was a problem hiding this comment.
Good comment and I agree with https://serverfault.com/a/797318 and probably 2/ (using it in the RUN call) is the cleaner way.
RazvanLiviuVarzaru
force-pushed
the
dev
branch
from
d7eb898
to
4be5d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs to be an ENV to be passed though to apt-get commands.
Probably worked due to lack of tty.