MDBF-778 Add CI support for no-galera installation of workers #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Many workflows are complaining: Same observed in: fix << in template >> |
grooverdan
force-pushed
the
no-galera
branch
3 times, most recently
from
c74efa4
to
64a4c3b
Compare
RazvanLiviuVarzaru
requested changes
Aug 21, 2024
4 tasks
grooverdan
changed the title
To solve chicken/egg problem of providing galera workers to build the galera-4 package. nogalera defined as string due to actions/runner#1483. It defaults to true, so the few build images that don't set it (mainly about to be EOL distros), or new distros that accidently omit it won't fail.
To support the nongalera workflow the galera removed lines must be workable when those lines are removed. This means if statements cannot be empty and there should be no lingering `fi` closures.
This ensure that hadolint doesn't fail with: /mnt/Dockerfile:28 SC2034 warning: ARCH appears unused. Verify use (or export if used externally).
RazvanLiviuVarzaru
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve chicken/egg problem of providing galera
workers to build the galera-4 package.
Once that happens, the nogalera can be removed form the attribute and the BB worker image will have the galera package needed to conduct galera tests.